Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Strange CSS Unicode Problems #96

Open
bmuenzenmeyer opened this issue Oct 24, 2017 · 8 comments
Open

Additional Strange CSS Unicode Problems #96

bmuenzenmeyer opened this issue Oct 24, 2017 · 8 comments
Assignees

Comments

@bmuenzenmeyer
Copy link
Member

image

image

@bradfrost
Copy link
Member

Very strange! The right-facing arrow makes sense, but the block-level comment shouldn't be doing that. Will take a look.

@bradfrost
Copy link
Member

@bmuenzenmeyer for these changes, what branch should I be working in? I want to make sure I'm on the straight and narrow.

@bmuenzenmeyer
Copy link
Member Author

@bradfrost branching off develop works just fine.

I tried to document this within https://github.com/pattern-lab/styleguidekit-assets-default/blob/master/.github/CONTRIBUTING.md#guidelines - let me know if you think we could improve that anywhere

@bradfrost
Copy link
Member

@bmuenzenmeyer The contributing guidelines are good. I guess I'm trying to figure out if this small change would necessitate its own branch, or could that work happen right on develop? That's typically how I operate with git flow, but just want to make sure I'm following conventions.

@frostyweather
Copy link
Contributor

@bmuenzenmeyer Is this within dist that you are seeing this? I am not seeing it on my pulled down version of this.

@bmuenzenmeyer
Copy link
Member Author

@frostyweather yes I see it in dist. I suspect it only manifests on Windows, since you guys haven't had problems yet right?

@frostyweather
Copy link
Contributor

@bmuenzenmeyer I have not had problems. Must be a windows thing. Maybe this sort of issue. https://stackoverflow.com/questions/44334638/css-content-character-rendering-strange

@frostyweather
Copy link
Contributor

Changed the arrow to Unicode value in CSS within the feature-pattern-info-panel branch. Hopefully this fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants