Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Question: Pattern Hiding & Lineage #30

Open
bmuenzenmeyer opened this issue Oct 11, 2016 · 5 comments
Open

Question: Pattern Hiding & Lineage #30

bmuenzenmeyer opened this issue Oct 11, 2016 · 5 comments

Comments

@bmuenzenmeyer
Copy link
Member

Seeking Clarification According to http://patternlab.io/docs/pattern-hiding.html, hidden patterns may be included in other patterns, but they will not be accessible from the navigation.

Should a user of Pattern Lab be able to reach this pattern using lineage, however?

Here is a screenshot for reference, where {{> atoms-hidden-button}} is prefixed with an underscore in the filesystem, does work as included, but is accessible via lineage.


The timeline for this clarification is not time-sensitive. It was brought up inside pattern-lab/patternlab-node#509 but may be decoupled from it should action be required.

Tagging core and spec-question because I am only hunting for what the cross-platform behavior should be.

/cc @pattern-lab/voting-members

@bmuenzenmeyer
Copy link
Member Author

cc @geoffp pertaining to your current PR

@bmuenzenmeyer bmuenzenmeyer changed the title Discussion: Pattern Hiding & Lineage Question: Pattern Hiding & Lineage Oct 11, 2016
@georgiee
Copy link

Hello,
I was just preparing to record an issue for this hidden pattern bug and found this.
What's the status for this topic? As the merge request obviously failed in Oct 2016 - are there any plans to fix it? I think it is a very visible error which needs to be fixed.

The impact of the current erroneous behaviour is:

  • Hidden Patterns are listed, but I hide them for a reason.
  • Patterns that are listed are clickable and lead me into a iframe in frame situation where obviously something is going wrong (see screen attached).

screen shot 2017-01-27 at 15 31 41

Should I create a new issue for this? Or is it maybe already on some roadmap?
Thanks!

@bmuenzenmeyer
Copy link
Member Author

@dmolsen do you have input on whether or not hidden patterns should be displayed within lineage, or if so, whether or not they should be navigable?

@bmuenzenmeyer
Copy link
Member Author

@bradfrost do you have any input on this from your client or personal work?

@bradfrost
Copy link
Member

@bradfrost do you have any input on this from your client or personal work?

In my opinion, the lineage should show hidden patterns. It's important to understand there are patterns that undergird the visible patterns. The hiding patterns feature was created mainly to shield clients and other stakeholders from some of the more nitty-gritty patterns that only really made sense in a bigger context. We didn't want them to get overwhelmed by seeing a massive array of components. But those patterns are still useful and important to the working team.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants