Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page: Add guidance for sticky page headers #3751

Closed
Tracked by #144
andrew-ronaldson opened this issue Sep 14, 2023 · 0 comments · Fixed by #4323
Closed
Tracked by #144

Page: Add guidance for sticky page headers #3751

andrew-ronaldson opened this issue Sep 14, 2023 · 0 comments · Fixed by #4323
Assignees
@edonehoo
Labels
Content PF6 Design guidelines

Comments

@andrew-ronaldson
Copy link
Contributor

In the Page component products can choose to make the page header sticky and all other content scrolls below the header. In this case the sticky header should have a dropshadow but it is not clearly defined in the docs that his should occur.

Recommend adding a one-liner about this for designers so they know to include it in their specs for developer implementation.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 14, 2023
@andrew-ronaldson andrew-ronaldson mentioned this issue Sep 14, 2023
Closed
@andrew-ronaldson andrew-ronaldson changed the title [Page component]Add guidance for sticky page headers [Page component] Add guidance for sticky page headers Sep 26, 2023
@andrew-ronaldson andrew-ronaldson mentioned this issue Sep 26, 2023
Closed
4 tasks
@mmenestr mmenestr moved this from Needs triage to Ready to assign in PatternFly Issues Oct 11, 2023
@edonehoo edonehoo added the Groom label Sep 12, 2024
@edonehoo edonehoo self-assigned this Sep 12, 2024
@edonehoo edonehoo added Content and removed Groom labels Sep 12, 2024
@andrew-ronaldson andrew-ronaldson moved this from Ready to assign to Not started in PatternFly Issues Oct 12, 2024
@andrew-ronaldson andrew-ronaldson changed the title [Page component] Add guidance for sticky page headers Page: Add guidance for sticky page headers Oct 12, 2024
@edonehoo edonehoo mentioned this issue Oct 15, 2024
Merged
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edonehoo edonehoo

Labels
Content PF6 Design guidelines
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(page): Mention need for drop shadow with sticky page headers. edonehoo/patternfly-org
2 participants
@andrew-ronaldson @edonehoo