Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - v6 docs framework - utilities need to reference pf-v6-u-[...] #3927

Closed
mcoker opened this issue Mar 22, 2024 · 1 comment · Fixed by #3931
Closed

Bug - v6 docs framework - utilities need to reference pf-v6-u-[...] #3927

mcoker opened this issue Mar 22, 2024 · 1 comment · Fixed by #3931
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented Mar 22, 2024

Mostly interested in the references to pf-v5-u-h-100 being updated on full page example pages, but I reckon all of them need to be updated since the classnames changed.

className={css('ws-preview-html', isFullscreenPreview && 'pf-v5-u-h-100')}

<div id={previewId} className={css(className, 'pf-v5-u-h-100')}>

Screenshot 2024-03-21 at 6 59 40 PM

FWIW I tried to make the change to submit a PR but my local dev server doesn't seem to be reloading with changes? I'm probably doing something wrong, but I tried starting the server with yarn [start/develop/develop:v5] and reloads don't seem to work. I'm also getting this webpack error

ERROR in ../../node_modules/@patternfly/design-tokens/patternfly-docs/content/tokensTable.js 47:6
Module parse failed: Unexpected token (47:6)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| 
|     return (
>       <div>
|         <div
|           className="ws-css-property"

webpack 5.76.3 compiled with 1 error in 41962 ms
@mcoker mcoker added the bug label Mar 22, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Mar 22, 2024
@mcoker mcoker changed the title Bug - v6 docs framework - utilities need to reference pf-v6 Bug - v6 docs framework - utilities need to reference pf-v6-u-[...] Mar 22, 2024
@nicolethoen nicolethoen self-assigned this Mar 25, 2024
@nicolethoen nicolethoen moved this from Needs triage to In Progress in PatternFly Issues Mar 25, 2024
@nicolethoen nicolethoen added this to the Penta alpha release milestone Mar 26, 2024
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues Mar 26, 2024
@nicolethoen
Copy link
Collaborator

Closed by #3931

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants