Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review community.md for removing utility classes, potentially replacing custom elements/styles #4021

Closed
wise-king-sullyman opened this issue May 14, 2024 · 1 comment · Fixed by #4127
Assignees

Comments

@wise-king-sullyman
Copy link
Collaborator

Followup from #4011

Per @mcoker in this comment and this other comment:

I don't know how much it matters, but it's worth noting there are a lot of utility classes used on this page where it looks like we have a stylesheet for other pages? I wonder if we should be more consistent. Also I wonder if we used <Text> headings, if we would need all of these margins and hwhat-not on the headings.

and

I'd expect we have <Grid> props that can replace the use of these .pf-v6-l-grid/.pf-m-* classes?

@nicolethoen
Copy link
Collaborator

closed by #4127

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Needs triage
Development

Successfully merging a pull request may close this issue.

3 participants