Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some react-icons have the wrong className #4047

Closed
mcoker opened this issue May 30, 2024 · 2 comments
Closed

Some react-icons have the wrong className #4047

mcoker opened this issue May 30, 2024 · 2 comments
Assignees
@nicolethoen
Milestone
Penta beta release

Comments

@mcoker
Copy link
Contributor

mcoker commented May 30, 2024

Looking at v6 staging on org, I noticed some of the icons are off-center in the <Label> component, and looks to be the result of some of them having .pf-v5-svg (incorrect) and others having .pf-v6-svg (correct).

Screenshot 2024-05-30 at 10 05 16 AM Screenshot 2024-05-30 at 10 05 06 AM
@mcoker mcoker added the bug label May 30, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 30, 2024
@mcoker
Copy link
Contributor Author

mcoker commented May 30, 2024

cc @kmcfaul @nicolethoen

@nicolethoen nicolethoen moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 4, 2024
@nicolethoen nicolethoen self-assigned this Jun 7, 2024
@nicolethoen nicolethoen moved this from Backlog to In Progress in PatternFly Issues Jun 10, 2024
@nicolethoen
Copy link
Collaborator

I believe this is now resolved in a newer version of staging.

@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Jun 10, 2024
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Extensions Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
None yet
Projects
PatternFly Issues
Archived in project
PatternFly Extensions
Archived in project
Milestone
Penta beta release
Development

No branches or pull requests
2 participants
@nicolethoen @mcoker