Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review cssVariables.css styles for replacing custom styles with existing styling options or tokenization #4059

Closed
wise-king-sullyman opened this issue Jun 4, 2024 · 0 comments · Fixed by #4110
Closed

Review cssVariables.css styles for replacing custom styles with existing styling options or tokenization #4059

wise-king-sullyman opened this issue Jun 4, 2024 · 0 comments · Fixed by #4110
Assignees
@wise-king-sullyman
Milestone
Penta beta release

Comments

@wise-king-sullyman
Copy link
Collaborator

We should evaluate these styles to determine if they're still needed and remove them if not.

If they are still needed we should update the currently commented out global styles with their proper token replacements.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Extensions Jun 4, 2024
@jessiehuff jessiehuff moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 4, 2024
@wise-king-sullyman wise-king-sullyman moved this from Backlog to In Progress in PatternFly Issues Jun 25, 2024
@wise-king-sullyman wise-king-sullyman mentioned this issue Jun 25, 2024
Merged
@wise-king-sullyman wise-king-sullyman linked a pull request Jun 25, 2024 that will close this issue
chore(styles): Remove custom styles for the css vars table #4110
Merged
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Jun 25, 2024
@kmcfaul kmcfaul closed this as completed Jul 11, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
None yet
Projects
PatternFly Issues
Archived in project
PatternFly Extensions
Status: Needs triage
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

chore(styles): Remove custom styles for the css vars table wise-king-sullyman/patternfly-org
3 participants
@wise-king-sullyman @nicolethoen @kmcfaul