Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review gdprBanner.css styles for replacing custom styles with existing styling options or tokenization #4062

Closed
wise-king-sullyman opened this issue Jun 4, 2024 · 1 comment · Fixed by #4082
Closed

Review gdprBanner.css styles for replacing custom styles with existing styling options or tokenization #4062

wise-king-sullyman opened this issue Jun 4, 2024 · 1 comment · Fixed by #4082
Assignees
@nicolethoen
Milestone
Penta beta release

Comments

@wise-king-sullyman
Copy link
Collaborator

We should evaluate these styles to determine if they're still needed and remove them if not.

If they are still needed we should update the currently commented out global styles with their proper token replacements.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Extensions Jun 4, 2024
@jessiehuff jessiehuff moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 4, 2024
@nicolethoen nicolethoen moved this from Backlog to Not started in PatternFly Issues Jun 6, 2024
@nicolethoen nicolethoen moved this from Not started to In Progress in PatternFly Issues Jun 7, 2024
@nicolethoen nicolethoen mentioned this issue Jun 7, 2024
Merged
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues Jun 7, 2024
@nicolethoen nicolethoen linked a pull request Jun 7, 2024 that will close this issue
fix: clean up gdpr banner styles #4082
Merged
@nicolethoen
Copy link
Collaborator

Closed by #4082

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 20, 2024
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Extensions Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
None yet
Projects
PatternFly Issues
Archived in project
PatternFly Extensions
Status: Done
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix: clean up gdpr banner styles nicolethoen/patternfly-org
2 participants
@wise-king-sullyman @nicolethoen