Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ColorFamily.css and ColorFamily.js styles for replacing custom styles with existing styling options or tokenization #4067

Closed
wise-king-sullyman opened this issue Jun 4, 2024 · 2 comments · Fixed by #4157
Assignees

Comments

@wise-king-sullyman
Copy link
Collaborator

wise-king-sullyman commented Jun 4, 2024

We should evaluate these styles to determine if they're still needed and remove them if not.

Along with the styles in ColorFamily.css, the inline styles in ColorFamily.js which reference removed global styles should also be addressed under this issue.

If they are still needed we should update the currently commented out global styles with their proper token replacements.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Extensions Jun 4, 2024
@wise-king-sullyman wise-king-sullyman changed the title Review ColorFamily.css styles for replacing custom styles with existing styling options or tokenization Review ColorFamily.css and ColorFamily.js styles for replacing custom styles with existing styling options or tokenization Jun 4, 2024
@jessiehuff jessiehuff moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 4, 2024
@jessiehuff jessiehuff self-assigned this Jun 5, 2024
@nicolethoen nicolethoen moved this from Backlog to In Progress in PatternFly Issues Jun 12, 2024
@nicolethoen
Copy link
Collaborator

Per conversation with design:

  • remove references to shadows
  • color families should not show palette or base tokens, only semantic tokens
  • see if we can have two columns under each accordion in the color families. One column for light theme semantic tokens which use these colors, one column for dark theme semantic tokens which use these colors
  • pick the three-ish most common colors for each category in the color swatch section

@nicolethoen nicolethoen linked a pull request Jul 25, 2024 that will close this issue
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues Jul 25, 2024
@nicolethoen
Copy link
Collaborator

Closed by #4157

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Needs triage
Development

Successfully merging a pull request may close this issue.

3 participants