Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to upgrade React tokens #4218

Closed
srambach opened this issue Aug 26, 2024 · 0 comments · Fixed by #4239
Closed

Document how to upgrade React tokens #4218

srambach opened this issue Aug 26, 2024 · 0 comments · Fixed by #4239
Assignees
Labels

Comments

@srambach
Copy link
Member

srambach commented Aug 26, 2024

Is this a new page or a change to an existing one?
We need to give some guidance on how to handle upgrading React tokens. They should be pointing to the var rather than the value so that dark theme will work properly.

For things like breakpoints, spacers, and widths we may be able to make a reliable substitution with a code mod.

For colors, let's add a code mod pointing to a new "placeholder" token set to a hot pink highlight color. This will make it easy to find places where semantic color tokens need to be selected.

Here's a start to the information that could be on this page. https://docs.google.com/document/d/1kjqv-gyuf2k9fewlUpnV3kpCmFbM_q6YhutPsjlOu88/edit?usp=sharing

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 26, 2024
@srambach srambach added this to the Penta final release milestone Aug 26, 2024
@nicolethoen nicolethoen moved this from Needs triage to Not started in PatternFly Issues Aug 27, 2024
@edonehoo edonehoo self-assigned this Aug 28, 2024
@edonehoo edonehoo linked a pull request Sep 6, 2024 that will close this issue
@kmcfaul kmcfaul added the P1 ⭐ label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants
@srambach @nicolethoen @kmcfaul @edonehoo and others