We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename endpoints:
get_running_detectors_list
get_running_detectors
get_allowed_detectors_list
get_allowed_detectors
get_last_run_number
get_current_run_number
get_next_run_number
advance_run_number
move advance_run_number (previously get_next_run_number, see above) from ENDPOINTS_GET to ENDPOINTS_POST (see also below)
ENDPOINTS_GET
ENDPOINTS_POST
move get_* endpoints of "slow broker" from ENDPOINTS_POST to ENDPOINTS_GET (see also below), specifically:
get_*
get_dap_settings
get_detector_settings
return dict for error_handler_500 consistent with other errors
error_handler_500
"status"
"message"
"state"
"error"
"failed"
consistent return dicts:
"pass"
set_pvlist
{"message": pv_list}
{"pv_list": pv_list, ...}
{"message": run_number}
{"run_number": run_number, ...}
take_pedestal
{"run_number": "0", "acquisition_number": "0", "unique_acquisition_number": "0"}
*_detector_settings
parameters
set_detector_settings
"changed_parameters"
*_dap_settings
{"dap_settings": dap_settings, ...}
set_dap_settings
{"changed_parameters": changed_parameters, ...}
"dap_settings"
"parameters"
reword all messages to be consistent, clear and helpful
update docs
requests.get(url, ...)
requests.post(url, ...)
WIP branch: https://github.com/paulscherrerinstitute/sf_daq_broker/tree/shutdown
The text was updated successfully, but these errors were encountered:
paulscherrerinstitute/slic@a7f04df paulscherrerinstitute/slic@a2e861d
Sorry, something went wrong.
NichtJens
No branches or pull requests
API breaking changes:
rename endpoints:
get_running_detectors_list
->get_running_detectors
get_allowed_detectors_list
->get_allowed_detectors
get_last_run_number
->get_current_run_number
get_next_run_number
->advance_run_number
move
advance_run_number
(previouslyget_next_run_number
, see above) fromENDPOINTS_GET
toENDPOINTS_POST
(see also below)move
get_*
endpoints of "slow broker" fromENDPOINTS_POST
toENDPOINTS_GET
(see also below), specifically:get_dap_settings
get_detector_settings
return dict for
error_handler_500
consistent with other errors"status"
->"message"
"state"
->"status"
"status"
:"error"
vs."failed"
->"error"
for all error casesconsistent return dicts:
"status"
:"pass"
(single occurrence: no channels in retrieve) ->"error"
set_pvlist
-> change{"message": pv_list}
to proper return dict incl."status"
and"message"
:{"pv_list": pv_list, ...}
get_last_run_number
andget_next_run_number
-> change{"message": run_number}
to proper return dict incl."status"
and"message"
:{"run_number": run_number, ...}
take_pedestal
-> remove{"run_number": "0", "acquisition_number": "0", "unique_acquisition_number": "0"}
*_detector_settings
-> move individual values intoparameters
dictget_detector_settings
-> add"message"
set_detector_settings
-> add"changed_parameters"
*_dap_settings
-> wrap result dict in actual return dict incl."status"
and"message"
, specifically:get_dap_settings
->{"dap_settings": dap_settings, ...}
set_dap_settings
->{"changed_parameters": changed_parameters, ...}
get_dap_settings
-> rename"dap_settings"
->"parameters"
reword all messages to be consistent, clear and helpful
update docs
Note regarding endpoint types:
ENDPOINTS_GET
==> userequests.get(url, ...)
ENDPOINTS_POST
==> userequests.post(url, ...)
Won't fix this shutdown:
set_dap_settings
?)WIP branch: https://github.com/paulscherrerinstitute/sf_daq_broker/tree/shutdownThe text was updated successfully, but these errors were encountered: