-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a struct to hold the RRule and allow composition #5
Comments
I like the idea, need to think about it. |
Great, good to hear. I create another issue regarding support for rruleset which I believe also would benefit from a proper rrule struct. |
Do you have any idea how structure like that could look like? Or maybe you can point me to some examples? |
this could be a decent start i guess:
|
Whats the benefit over simple map? |
well it's structured, so you know exactly which fields can exist and you can have default values as well. You can also pattern match on the struct itself to enforce it which is pretty good when designing an API that revolve around manipulating some data |
Sorry in advance for creating many issues for you... ;)
Right now the provided API is very adhoc, there is mainly 2 entry points depending if you need a stream or not and there is no struct being used to capture the RRule.
I was wondering if the api could evolve in a way where the starting point is the creation of that struct which then can be piped into functions such as:
of course it would allow composition such as:
What do you think ?
The text was updated successfully, but these errors were encountered: