Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire.beginTransmission() and Wire.endTransmission() should not be used together with Wire.requestFrom(). #44

Open
Koepel opened this issue Sep 6, 2018 · 0 comments
Open

Wire.beginTransmission() and Wire.endTransmission() should not be used together with Wire.requestFrom(). #44

Koepel opened this issue Sep 6, 2018 · 0 comments

Comments

@Koepel
Copy link

Koepel commented Sep 6, 2018

The Wire.beginTransmission() and Wire.endTransmission() should only be used when writing data.
I noticed two files where they were used before and after a Wire.requestFrom(). Those can be removed.
Explanation: Common-mistakes, number 2 and 3.

  • espressif/esp32/arduino/sketchbook/ESP32_SI7060_INA219/i2c_SI7060.cpp (currently at line 31 and 34)
  • espressif/esp32/arduino/sketchbook/ESP32_i2c_Si7021_oled/ESP32_i2c_Si7021_oled.ino (currently at line 27 and 31).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Koepel