Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Scientific notation search terms #263

Open
tangkong opened this issue Jun 9, 2022 · 0 comments
Open

BUG: Scientific notation search terms #263

tangkong opened this issue Jun 9, 2022 · 0 comments
Labels
CLI Command-line interface

Comments

@tangkong
Copy link
Contributor

tangkong commented Jun 9, 2022

One edge case I didn't consider is scientific notation. client.search_regex won't consider something 100 == 1e2, so we basically pray that the str(float(str)) conversion produces something that matches the database.

At this point, we're patching over an interface that really doesn't seem to handle numerics correctly. This is probably worth a deeper look, perhaps at other search methods on the backends.

Originally posted by @tangkong in #261 (comment)

@tangkong tangkong added the CLI Command-line interface label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Command-line interface
Projects
None yet
Development

No branches or pull requests

1 participant