Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the background image #1

Closed
divyam3897 opened this issue Sep 30, 2017 · 10 comments
Closed

Modify the background image #1

divyam3897 opened this issue Sep 30, 2017 · 10 comments

Comments

@divyam3897
Copy link
Contributor

Replace the background image with pclub logo

ashwani99 added a commit to ashwani99/website that referenced this issue Sep 30, 2017
Change the background image as the PCLUB logo and center the background image.
@ashwani99
Copy link
Contributor

@divyam3897 Does this look good?

@deveshd2k
Copy link

use this image for high resolution:
newlogo

@ashwani99
Copy link
Contributor

@deveshd2k Don't you think it is still too small? Stretching this to fit screen would blur the image.

@divyam3897
Copy link
Contributor Author

@ashwani99 can you make a .svg similar to the same and make a div for it below the navbar and not use it as background image?

@ashwani99
Copy link
Contributor

@divyam3897 Sorry, I'm not good with logo designing stuff. As a suggestion, I think there has to be much more black background around the logo so that it will prevent the actual logo becoming too large when we put it as a background. What do you think?

@deveshd2k
Copy link

i tried making svg but only black and white color is there after conversion. No green color and background
effect is also gone.

@deveshd2k
Copy link

can you please get me the actual resolution in pixels you want for image??

@ashwani99
Copy link
Contributor

@deveshd2k I am not too sure of this because depending on the screen size the background will become bad. Maybe a 1280x1024 would be fine. Also, is it really necessary to put the logo as background?

@divyam3897
Copy link
Contributor Author

It won't be the background any more , see the issue of adding about us, it would just be a section of some finite height below the navbar

@divyam3897
Copy link
Contributor Author

It has a seperate issue now #77 So closing this duplicate one which is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants