Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] description gets replaced between videos #28

Open
mock-rye opened this issue Sep 10, 2020 · 2 comments
Open

[bug] description gets replaced between videos #28

mock-rye opened this issue Sep 10, 2020 · 2 comments

Comments

@mock-rye
Copy link

noticed this one a bit ago but thought maybe it was a one-off, and now it happened again
will update if I find a way to replicate but it seems to just happen at random so far

@pcouy
Copy link
Owner

pcouy commented Sep 11, 2020

The userscript has always had issues and seemingly random bugs. It is getting worse because Google is slowly updating YouTube while this userscript was last updated 7 months ago.

Maintaining this is more complicated than I would have ever imagined. This was only meant to be a quick and dirty fix for myself that I released because ther was no other way arround YouTube's dumb design. I do not want to spend the time to maintain it when Google can break it anytime by updating YouTube and it still somewhat works for me.

However, you are more than welcome to fork it (the script is under MIT License so you are free to do whatever you want to it as long as you keep it under the same license). You can also check-out @Seneral 's fork, he did some interesting things a while ago that have not been merged into this repo

@Seneral
Copy link
Contributor

Seneral commented Sep 11, 2020

Well my fork, while it does have some improvements, is in many ways in the same position. My main reason for this script was music content being translated, and since I developed my own music web app (FlagPlayer) I don't use YouTube for music anymore so there goes my main reason to keep it updated.
I can recommend disabling the description code, then descriptions will be translated but titles not. Check for the section labeled "Replace Main Video Description". Before the "if", add "/" (without quotes), and after the closing "}", add "/". That disables that section.
The main problem with updating this code is that the way YouTube inserts content and the timing it does so is unpredictable and not very friendly with changes it doesn't expect. Think whenever you load the page, it could immediately show the description, but it does not - it delays it for seconds, for some odd reason, until some lther content is loaded. And technically you'd have to detect this separately from page load in order to be sure YouTube doesn't mess with our changes until next page load. This falls apart on live streams where it appends the new description, not clearing our changes, so that would have to be addressed, to. A lot of effort for something YouTube could change at any point (And they do change random stuff without reason, regularly have to update FlagPlayer because they change stuff).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants