-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash with simple_navigation 4.0.3 #13
Comments
It's possible they made some backwards-incompatible changes in 4.x, I'll try to find time to test this in the next week or so. |
The same issue. |
Until I can investigate how we're meant to do this on 4.x, I've released v1.0.1 which restricts compatibility to simple-navigation < 4.0.0. |
1.0.1 seems to have an extra
Thanks for the great work. |
Also in 1.0.1, 1246eee is giving me:
|
Sorry, that's embarrassing - I forgot that I haven't done a release in a while, there was some in-flight code uploaded by accident. I've yanked v1.0.1 and v1.0.2 will be published shortly. |
All good - it was Friday lunchtime after all. (I'm in Sydney) Cheers. |
I don't use this code much these days (been moving away from rails dev). Should maybe have bumped the minor version for this release because there's a bit of new code, but v1.0.2 is up now. |
I'm just rollback simple navigation to 4.0.2 |
I am not sure if it can work with simple-navigation prior 4.0.0 or not, so I simply forced the gemspec to work only with ver 4+.
undefined method `html_options=' for #SimpleNavigation::Item:0x000000055acf30
The code in _header.html.haml just calls a standard renderer:
The text was updated successfully, but these errors were encountered: