Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with simple_navigation 4.0.3 #13

Open
yld opened this issue May 20, 2015 · 9 comments
Open

Crash with simple_navigation 4.0.3 #13

yld opened this issue May 20, 2015 · 9 comments

Comments

@yld
Copy link

yld commented May 20, 2015

undefined method `html_options=' for #SimpleNavigation::Item:0x000000055acf30

NoMethodError - undefined method `html_options=' for #<SimpleNavigation::Item:0x000000055acf30>:
  simple-navigation-bootstrap (1.0.0) lib/simple_navigation/rendering/renderer/bootstrap.rb:55:in `tag_for'
  simple-navigation-bootstrap (1.0.0) lib/simple_navigation/rendering/renderer/bootstrap.rb:11:in `block in render'
  simple-navigation-bootstrap (1.0.0) lib/simple_navigation/rendering/renderer/bootstrap.rb:7:in `render'
  simple-navigation (4.0.3) lib/simple_navigation/item_container.rb:103:in `render'
  simple-navigation (4.0.3) lib/simple_navigation/helpers.rb:88:in `render_navigation'
  actionpack (4.2.1) lib/abstract_controller/helpers.rb:67:in `render_navigation'
app/views/application/_header.html.haml:14:in `_app_views_application__header_html_haml___3547199929432777363_108950520'
(...)

The code in _header.html.haml just calls a standard renderer:

= render_navigation expand_all: true, level: 1..2, renderer: :bootstrap
@pdf
Copy link
Owner

pdf commented May 20, 2015

It's possible they made some backwards-incompatible changes in 4.x, I'll try to find time to test this in the next week or so.

@xskif
Copy link

xskif commented May 21, 2015

The same issue.

@pdf
Copy link
Owner

pdf commented May 22, 2015

Until I can investigate how we're meant to do this on 4.x, I've released v1.0.1 which restricts compatibility to simple-navigation < 4.0.0.

@andrew2005
Copy link

1.0.1 seems to have an extra end introduced in d5bbaf8:

simple-navigation-bootstrap-1.0.1/lib/simple_navigation/rendering/renderer/bootstrap.rb:71: syntax error, unexpected keyword_end, expecting end-of-input (SyntaxError)

Thanks for the great work.

@andrew2005
Copy link

Also in 1.0.1, 1246eee is giving me:

undefined method `dropdown' for #<SimpleNavigation::ItemContainer:0x007fdc45f56508>

@pdf
Copy link
Owner

pdf commented May 22, 2015

Sorry, that's embarrassing - I forgot that I haven't done a release in a while, there was some in-flight code uploaded by accident. I've yanked v1.0.1 and v1.0.2 will be published shortly.

@andrew2005
Copy link

All good - it was Friday lunchtime after all. (I'm in Sydney)

Cheers.

@pdf
Copy link
Owner

pdf commented May 22, 2015

I don't use this code much these days (been moving away from rails dev). Should maybe have bumped the minor version for this release because there's a bit of new code, but v1.0.2 is up now.

@xskif
Copy link

xskif commented May 22, 2015

I'm just rollback simple navigation to 4.0.2

zealot128 referenced this issue in pzgz/simple-navigation-bootstrap Dec 2, 2015
I am not sure if it can work with simple-navigation prior 4.0.0 or not, so I simply forced the gemspec to work only with ver 4+.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants