-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support: load config from external repository #618
Comments
Hi @peaceiris, I see your 👀 reaction to the issue, but I am not very good at analyzing emoji reactions. Is there something unclear or questions you have about it? I think this action is very useful (thank you for that!), and the ability to use it centralized for all repos of an organization would be awesome. |
Thank you for your great suggestion! A few months ago, I considered remaking the config_file input to fetch a custom remote config file like https://github.com/actions/labeler. That was the plan in my mind. It can satisfy your demand. I will work on this in the next major version v2 https://github.com/peaceiris/actions-label-commenter/milestone/2 |
Hi, there. Thank you @alombarte for suggesting this.
|
The new config_file has been already implemented, but not released. actions-label-commenter/src/classes/config.ts Line 125 in 2e98b60
|
Hi @peaceiris , I am amazed with your responsiveness.... this is so cool! I have added the commit SHA to a test workflow, and here is the error log: With the follwoing lines
The log is:
|
Ahh, maybe the called workflow runs on krakendio/krakend-schema, not krakendio/.github I will add support fetching a file with the HTTPS protocol for that case. - uses: peaceiris/actions-label-commenter@v2
with:
config_file: https://github.com/krakendio/.github/blob/main/.github/label-commenter-config.yml
# or config_file: https://raw.githubusercontent.com/krakendio/.github/main/.github/label-commenter-config.yml |
That's correct. The idea is having a single configuration file centralized in the I am eager to see this implemented, and in fact I will wait until it's done to apply it to all the projects (~50) at once. Thanks! |
Hi @peaceiris , I was wondering if you had a look to retrieving the |
Hello @peaceiris , Are there any plans to support this functionality? |
Checklist
Describe your question
Hi,
I was testing the action and I got the impression that the configuration file is always assumed to live inside the repository whose job is calling the action. When using the special
.github
repository (not folder) along with the health files and other cross-organization workflows, the action fails to load the configuration.For instance, in your github.com/ORGANIZATION/.github repository, you have a file
github.com/ORGANIZATION/.github/.github/workflows/label-commenter.yml
with content:The
on
specifies the calling from outside. And then you have the config in its default location, also inside the.github
repo. Then you call it from another repo (github.com/ORGANIZATION/some-repo) with its workflow:The configuration file will fail to load as it is looking from within the calling repo, but the config lives centralized with the label commenter action.
Is there a way to specify a different organization and repo to load the configuration file, or to load it embedded using
with
or similar in one file? Otherwise the configuration file has to be copied in all repos of the organization.Thank you!
Relevant links
Relevant log output
Action failed with error "not found .github/label-commenter-config.yml"
Additional context.
No response
The text was updated successfully, but these errors were encountered: