Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support boroughs #257

Open
missinglink opened this issue Apr 8, 2019 · 0 comments
Open

support boroughs #257

missinglink opened this issue Apr 8, 2019 · 0 comments

Comments

@missinglink
Copy link
Member

PR pelias/postal-cities#2 allows for borough placetypes to be imported additionally to the locality placetype.

It looks like there will need to be some minor edits made here to support this new functionality.

The file https://github.com/pelias/wof-admin-lookup/blob/master/src/usePostalCity.js contains some code which is tied specifically to the locality placetype which will need to be adjusted.

I believe https://github.com/pelias/wof-admin-lookup/blob/master/src/postalCityMap.js is fine as-is, although the code comment lists only 5 columns, none of which are the placetype, whereas it looks like placetype is being recorded in the lastline repo here https://github.com/pelias/lastline/blob/master/src/placeholderLookup.js

This PR is to do an end-to-end evaluation of using additional placetypes and to test it out for boroughs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@missinglink