Add PELIMOJI_SIZE_MULTIPLIER configuration setting
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PELIMOJI_SIZE_MULTIPLIER expects a fairly small int that acts as a size multiplier for the displayed emojis
justinmayer
reviewed
Feb 25, 2025
README.md
Outdated
| @@ -30,6 +30,11 @@ By default this plugin operates on source content files with the following file | |||
| PELIMOJI_FILE_EXTENSIONS = ["md", "html", "rst", "txt"] | |||
| ``` | |||
|
|
|||
| `PELIMOJI_SIZE_MULTIPLIER` can be specified to increase the size of all emojis when they are rendered | |||
There was a problem hiding this comment.
It could be helpful to add a bit more information for users:
- The default value (
1). - Somehow make it clearer that a value of
2is two times larger than the default,3is 3x, etc. - Add a colon at the end (or a period if the setting description grows to more than one sentence).
There was a problem hiding this comment.
Just pushed an update to the wording; let me know if further tweaks are needed
justinmayer
reviewed
Feb 25, 2025
justinmayer
changed the title
PELIMOJI_SIZE_MULTIPLIER configuration setting
justinmayer
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Once again, nice work, Weston! I made a small tweak to the documentation wording, rebased this branch on top of my changes in #17, and added a release file so a new package version will be automatically published to PyPI via AutoPub when either @KayOhtie or I use the Squash & Merge button to squash these commits and merge them.
|
@KayOhtie: Any thoughts about this pull request before the squash, merge, and release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PELIMOJI_SIZE_MULTIPLIER expects a fairly small int that acts as a size multiplier for the displayed emojis. Closes #15.