From a6e51704634f0a5f78d393feac3846873a46c471 Mon Sep 17 00:00:00 2001
From: Justin Zhang <judtin@seas.upenn.edu>
Date: Thu, 25 Apr 2024 03:12:33 -0400
Subject: [PATCH] Working DLA to LAS pipeline

---
 analytics/analytics.py            | 36 ++++++++++++++++++++++---------
 tests/analytics/test_analytics.py | 33 ++++++++++++++++++++++------
 tests/analytics/test_views.py     | 25 ---------------------
 3 files changed, 53 insertions(+), 41 deletions(-)
 delete mode 100644 tests/analytics/test_views.py

diff --git a/analytics/analytics.py b/analytics/analytics.py
index bb8d79a..e2448ae 100644
--- a/analytics/analytics.py
+++ b/analytics/analytics.py
@@ -1,13 +1,13 @@
 import json
 from concurrent.futures import ThreadPoolExecutor
-from enum import Enum
+from enum import IntEnum
 from typing import Optional
 
-import requests
 from django.utils import timezone
 
+from identity.identity import _refresh_if_outdated, container
 
-class Product(Enum):
+class Product(IntEnum):
     OTHER = 0
     MOBILE_IOS = 1
     MOBILE_ANDROID = 2
@@ -30,23 +30,32 @@ def __init__(
         product: Product,
         pennkey: Optional[str],
         timestamp=timezone.now(),
-        data=dict(),
+        data=list(),
     ):
-        self.product = str(product)
+        self.product = product.value
         self.pennkey = pennkey
         self.timestamp = timestamp.timestamp()
         self.data = data
 
     def to_json(self):
-        return json.dumps(vars(self))
+        return json.loads(json.dumps(vars(self)))
 
+from requests import Session
+
+class NoRebuildAuthSession(Session):
+    def rebuild_auth(self, prepared_request, response):
+        """
+        No code here means requests will always preserve the Authorization
+        header when redirected.
+        Be careful not to leak your credentials to untrusted hosts!
+        """
 
 class LabsAnalytics:
     """
     Python wrapper for async requests to Labs Analytics Engine
     """
 
-    ANALYTICS_URL = "https://jsonplaceholder.typicode.com/posts"
+    ANALYTICS_URL = "https://analytics.pennlabs.org/analytics"
     POOL_SIZE = 10
 
     def __new__(cls, *args, **kwargs):
@@ -54,12 +63,19 @@ def __new__(cls, *args, **kwargs):
             cls.instance = super(LabsAnalytics, cls).__new__(cls)
         return cls.instance
 
-    def __init__(self):
+    def __init__(self): 
         self.executor = ThreadPoolExecutor(max_workers=self.POOL_SIZE)
 
     def submit(self, txn: AnalyticsTxn):
-        headers = {}
+        _refresh_if_outdated()
+
+        headers = {
+            "Authorization": f"Bearer {container.access_jwt.serialize()}",
+            "Content-Type": "application/json"
+        }
         self.executor.submit(self.request_job, txn.to_json(), headers)
 
     def request_job(self, json, headers):
-        requests.post(self.ANALYTICS_URL, json=json, headers=headers)
+        session = NoRebuildAuthSession()
+        session.post(url=self.ANALYTICS_URL, json=json, headers=headers)
+
diff --git a/tests/analytics/test_analytics.py b/tests/analytics/test_analytics.py
index 8fb8655..a19944f 100644
--- a/tests/analytics/test_analytics.py
+++ b/tests/analytics/test_analytics.py
@@ -2,7 +2,8 @@
 
 from django.test import TestCase
 
-from analytics.analytics import AnalyticsTxn, Product
+from analytics.analytics import AnalyticsTxn, Product, LabsAnalytics
+from identity.identity import attest
 
 
 class AnalyticsTxnTestCase(TestCase):
@@ -10,13 +11,33 @@ def test_analytics_txn(self):
         data = {
             "product": Product.MOBILE_BACKEND,
             "pennkey": None,
-            "data": {"key": "backend", "value": "data"},
+            "data": [{"key": "backend", "value": "data"}],
         }
 
         txn = AnalyticsTxn(**data)
         data_json = txn.to_json()
-        data_dict = json.loads(data_json)
+        # data_dict = json.dumps(data_json)
 
-        self.assertEqual("MOBILE_BACKEND", data_dict["product"])
-        self.assertIsNone(data_dict["pennkey"])
-        self.assertIn("timestamp", data_dict)
+        self.assertEqual(Product.MOBILE_BACKEND.value, int(data_json["product"]))
+        self.assertIsNone(data_json["pennkey"])
+        self.assertIn("timestamp", data_json)
+
+class AnalyticsSubmission(TestCase):
+
+    # TODO: Add mocked test cases for Analytics
+
+    def setUp(self):
+        attest()
+        self.analytics_wrapper = LabsAnalytics()
+
+    def test_submit(self):
+        data = {
+            "product": Product.MOBILE_BACKEND,
+            "pennkey": "hi",
+            "data": [{"key": "backend", "value": "data"}],
+        }
+
+        txn = AnalyticsTxn(**data)
+
+        self.analytics_wrapper.submit(txn)
+        assert False
\ No newline at end of file
diff --git a/tests/analytics/test_views.py b/tests/analytics/test_views.py
deleted file mode 100644
index 0f5af24..0000000
--- a/tests/analytics/test_views.py
+++ /dev/null
@@ -1,25 +0,0 @@
-from django.contrib.auth import get_user_model
-from django.test import Client, TestCase
-from django.urls import reverse
-
-
-class JWTViewTestCase(TestCase):
-    def setUp(self):
-        self.client = Client()
-        self.User = get_user_model()
-
-    def test_set_next(self):
-        x = self.client.get(reverse("analytics:attest"))
-        print(x.content)
-        self.assertFalse(True)
-
-
-class RefreshJWTViewTestCase(TestCase):
-    def setUp(self):
-        self.client = Client()
-        self.User = get_user_model()
-
-    def test_set_next(self):
-        x = self.client.post(reverse("analytics:refresh"), {"refresh": ""})
-        print(x.content)
-        self.assertFalse(True)