From 247e0fbba42dc9e0e0a5c0f2aa18a099f1449548 Mon Sep 17 00:00:00 2001
From: charisgao <charis.m.gao@gmail.com>
Date: Fri, 29 Sep 2023 18:28:21 -0400
Subject: [PATCH] moved feedback form

---
 .../Course/CourseSidebarInstructorList.tsx    | 13 ----------
 .../components/Home/Dashboard/Dashboard.tsx   |  4 +---
 frontend/components/Home/HomeSidebar.tsx      | 10 --------
 frontend/components/common/Feedback.tsx       | 16 -------------
 frontend/components/common/Footer.tsx         | 24 +++++++++----------
 5 files changed, 12 insertions(+), 55 deletions(-)
 delete mode 100644 frontend/components/common/Feedback.tsx

diff --git a/frontend/components/Course/CourseSidebarInstructorList.tsx b/frontend/components/Course/CourseSidebarInstructorList.tsx
index 87bce39a0..a8dba47e1 100644
--- a/frontend/components/Course/CourseSidebarInstructorList.tsx
+++ b/frontend/components/Course/CourseSidebarInstructorList.tsx
@@ -1,13 +1,8 @@
 import { Header, Icon, List, Segment } from "semantic-ui-react";
-import { useMediaQuery } from "@material-ui/core";
 import { useLeadership } from "../../hooks/data-fetching/course";
 import { Membership } from "../../types";
 import { leadershipSortFunc } from "../../utils";
 import { prettifyRole } from "../../utils/enums";
-import Feedback from "../common/Feedback";
-import styles from "../../styles/landingpage.module.css";
-import { MOBILE_BP } from "../../constants";
-import Footer from "../common/Footer";
 
 interface CourseSidebarInstructorListProps {
     courseId: number;
@@ -23,7 +18,6 @@ const CourseSidebarInstructorList = ({
         leadershipRaw
     );
     const leadership = leadershipUnsorted.sort(leadershipSortFunc);
-    const isMobile = useMediaQuery(`(max-width: ${MOBILE_BP})`);
 
     return (
         <>
@@ -54,13 +48,6 @@ const CourseSidebarInstructorList = ({
                     })}
                 </List>
             </Segment>
-            {isMobile ? (
-                <Footer showFeedback />
-            ) : (
-                <div role="button" className={`${styles["about-dashboard"]}`}>
-                    <Feedback />
-                </div>
-            )}
         </>
     );
 };
diff --git a/frontend/components/Home/Dashboard/Dashboard.tsx b/frontend/components/Home/Dashboard/Dashboard.tsx
index 23fccbdbc..27166007c 100644
--- a/frontend/components/Home/Dashboard/Dashboard.tsx
+++ b/frontend/components/Home/Dashboard/Dashboard.tsx
@@ -2,7 +2,6 @@ import { useContext, useState, useEffect } from "react";
 import { Grid, Header, Segment, Message } from "semantic-ui-react";
 import Alert from "@material-ui/lab/Alert";
 import Snackbar from "@material-ui/core/Snackbar";
-import { useMediaQuery } from "@material-ui/core";
 import InstructorCourses from "./InstructorCourses";
 import StudentCourses from "./StudentCourses";
 import Footer from "../../common/Footer";
@@ -13,7 +12,6 @@ import { isLeadershipRole } from "../../../utils/enums";
 import {
     CHANGELOG_TOKEN,
     SPRING_2023_TRANSITION_MESSAGE_TOKEN,
-    MOBILE_BP,
 } from "../../../constants";
 import ModalShowNewChanges from "./Modals/ModalShowNewChanges";
 import updatedMd from "../../Changelog/changelogfile.md";
@@ -169,7 +167,7 @@ const Dashboard = () => {
                 </Alert>
             </Snackbar>
 
-            <Footer showFeedback={useMediaQuery(`(max-width: ${MOBILE_BP})`)} />
+            <Footer />
             <ModalShowNewChanges openModal={logModal} setOpen={setLogModal} />
         </Grid.Column>
     );
diff --git a/frontend/components/Home/HomeSidebar.tsx b/frontend/components/Home/HomeSidebar.tsx
index e8f3d127d..7171b4ce5 100644
--- a/frontend/components/Home/HomeSidebar.tsx
+++ b/frontend/components/Home/HomeSidebar.tsx
@@ -2,19 +2,14 @@ import { useState } from "react";
 
 import { Segment, Menu, Grid, Image } from "semantic-ui-react";
 import Link from "next/link";
-import { useMediaQuery } from "@material-ui/core";
 
 import { useRouter } from "next/router";
 import SignOutButton from "../SignOut";
-import styles from "../../styles/landingpage.module.css";
 import AboutModal from "../common/AboutModal";
-import Feedback from "../common/Feedback";
-import { MOBILE_BP } from "../../constants";
 
 const Sidebar = () => {
     const router = useRouter();
     const [showAboutModal, setShowAboutModal] = useState(false);
-    const isMobile = useMediaQuery(`(max-width: ${MOBILE_BP})`);
 
     return (
         <Grid.Column width={3}>
@@ -69,11 +64,6 @@ const Sidebar = () => {
                     <SignOutButton />
                 </Menu>
             </Segment>
-            {!isMobile && (
-                <div role="button" className={`${styles["about-dashboard"]}`}>
-                    <Feedback />
-                </div>
-            )}
             <AboutModal
                 open={showAboutModal}
                 closeFunc={() => setShowAboutModal(false)}
diff --git a/frontend/components/common/Feedback.tsx b/frontend/components/common/Feedback.tsx
deleted file mode 100644
index 9af73349c..000000000
--- a/frontend/components/common/Feedback.tsx
+++ /dev/null
@@ -1,16 +0,0 @@
-import styles from "../../styles/landingpage.module.css";
-
-const Feedback = () => {
-    return (
-        <a
-            href="https://airtable.com/shrIZxIjyAE3gOUSg"
-            target="_blank"
-            rel="noreferrer"
-            className={`${styles.about}`}
-        >
-            <p>Feedback</p>
-        </a>
-    );
-};
-
-export default Feedback;
diff --git a/frontend/components/common/Footer.tsx b/frontend/components/common/Footer.tsx
index 21a72e3f8..32f707078 100644
--- a/frontend/components/common/Footer.tsx
+++ b/frontend/components/common/Footer.tsx
@@ -3,13 +3,8 @@ import { useState } from "react";
 import { Container } from "semantic-ui-react";
 
 import AboutModal from "./AboutModal";
-import Feedback from "./Feedback";
 
-interface FooterProps {
-    showFeedback?: boolean;
-}
-
-export default function Footer({ showFeedback }: FooterProps) {
+export default function Footer() {
     const [showModal, setShowModal] = useState(false);
     return (
         <>
@@ -38,14 +33,17 @@ export default function Footer({ showFeedback }: FooterProps) {
                     Friends
                 </span>{" "}
                 |{" "}
-                <Link href="/changelog">
+                <Link legacyBehavior href="/changelog">
                     <a>Changelog</a>
-                </Link>
-                {showFeedback && (
-                    <div role="button" style={{ marginTop: "8px" }}>
-                        <Feedback />
-                    </div>
-                )}
+                </Link>{" "}
+                |{" "}
+                <a
+                    href="https://airtable.com/shrIZxIjyAE3gOUSg"
+                    target="_blank"
+                    rel="noopener noreferrer"
+                >
+                    Feedback
+                </a>
             </Container>
             <AboutModal
                 open={showModal}