From 1c08d39ca572f7bfece1a3633e8b8c4bec5669fa Mon Sep 17 00:00:00 2001
From: Eunsoo Shin <me@esinx.net>
Date: Mon, 14 Aug 2023 14:58:06 +0900
Subject: [PATCH] fix(club.membership_count): deprecate club membership count,
 use club.members.length instead

---
 frontend/components/ClubPage/InfoBox.tsx | 6 +++---
 frontend/types.ts                        | 4 ++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/frontend/components/ClubPage/InfoBox.tsx b/frontend/components/ClubPage/InfoBox.tsx
index e4e15eda7..a943235e6 100644
--- a/frontend/components/ClubPage/InfoBox.tsx
+++ b/frontend/components/ClubPage/InfoBox.tsx
@@ -40,9 +40,9 @@ const InfoBox = (props: InfoBoxProps): ReactElement | null => {
       field: 'size',
       icon: 'user',
       alt: 'members',
-      text: `${props.club.membership_count} Registered (${getSizeDisplay(
-        props.club.size,
-      )})`,
+      text: `${
+        props.club.membership_count ?? props.club.members.length
+      } Registered (${getSizeDisplay(props.club.size)})`,
     },
     {
       field: 'accepting_members',
diff --git a/frontend/types.ts b/frontend/types.ts
index 4a7384d7e..310907dac 100644
--- a/frontend/types.ts
+++ b/frontend/types.ts
@@ -169,6 +169,10 @@ export interface Club {
   linkedin: string
   listserv: string
   members: Membership[]
+  /**
+   * @deprecated
+   * use `members.length` instead
+   */
   membership_count: number
   name: string
   recruiting_cycle: ClubRecruitingCycle