Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multipart requests #110

Open
mukel opened this issue Jun 22, 2018 · 7 comments
Open

Support multipart requests #110

mukel opened this issue Jun 22, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mukel
Copy link

mukel commented Jun 22, 2018

Very slick library, but can't send multipart requests out-of-the-box. Other libraries I've tried do support it but have other caveats:

  • RosHttp but not as nice as this one (and a bit buggy).
  • sttp but doesn't support Node.js ATM.
@pepegar
Copy link
Owner

pepegar commented Jun 22, 2018

Hey @mukel ! Yeah, multipart is something we definitely want to introduce. I think the idea would be to create a new MultipartEntity, and map it to the underlying implementations.

@pepegar
Copy link
Owner

pepegar commented Jun 22, 2018

CC/ @antonkulaga

@pepegar pepegar added enhancement New feature or request help wanted Extra attention is needed labels Jun 22, 2018
@pepegar pepegar self-assigned this Jul 24, 2018
@pepegar pepegar removed the help wanted Extra attention is needed label Jul 24, 2018
@pepegar
Copy link
Owner

pepegar commented Jul 24, 2018

Working on it now

@antonkulaga
Copy link
Contributor

@pepegar any updates?

@pepegar
Copy link
Owner

pepegar commented Dec 24, 2018

Hi @antonkulaga. I haven't had much time lately to invest in Hammock. I'll try to update it here when feature gets to a reviewable state.

@miciek
Copy link
Collaborator

miciek commented Dec 24, 2018

hi @pepegar, @antonkulaga. I will try to take over this one. Will keep you posted.

@pepegar
Copy link
Owner

pepegar commented Dec 24, 2018

Thanks @miciek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants