From 21a0f0725947f2096d3af3ae491ba1bdffabb2a5 Mon Sep 17 00:00:00 2001 From: Pera Jovic Date: Sat, 12 Nov 2016 16:31:30 +0100 Subject: [PATCH] Workaround for ManagedBy::update() problem in ProxyManager This method signature should be compatible with 7.1 nullable types `?string $firstname, ?string $lastname`. ATM (12.11.2016.) there are bugs in two projects: 1. https://github.com/zendframework/zend-code/issues/85 2. https://github.com/Ocramius/ProxyManager/pull/327 These are blockers for 7.1 syntax. --- src/Filos/FrameworkBundle/Model/ManagedBy.php | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/Filos/FrameworkBundle/Model/ManagedBy.php b/src/Filos/FrameworkBundle/Model/ManagedBy.php index b6ce230..6cac450 100644 --- a/src/Filos/FrameworkBundle/Model/ManagedBy.php +++ b/src/Filos/FrameworkBundle/Model/ManagedBy.php @@ -67,7 +67,17 @@ public static function create( return $managedBy; } - public function update(string $email, ?string $firstname, ?string $lastname) + /** + * @todo + * + * This method signature should be compatible with 7.1 nullable types `?string $firstname, ?string $lastname`. + * ATM (12.11.2016.) there are bugs in two projects: + * 1. https://github.com/zendframework/zend-code/issues/85 + * 2. https://github.com/Ocramius/ProxyManager/pull/327 + * + * They are blockers for 7.1 syntax. + */ + public function update(string $email, string $firstname = null, string $lastname = null) { $this->email = $email; $this->firstname = $firstname;