From d4bf2d2c70a40c108ef9e4d03861cf21cfeed9cb Mon Sep 17 00:00:00 2001
From: Per Lindgren <per.lindgren@ltu.se>
Date: Mon, 31 Jul 2023 11:21:58 +0200
Subject: [PATCH] polish

---
 .vscode/settings.json    | 5 +++--
 CHANGELOG.md             | 4 ++++
 riscv/asm.s              | 1 +
 riscv/riscv_asm/build.rs | 5 -----
 src/components/mem.rs    | 1 +
 5 files changed, 9 insertions(+), 7 deletions(-)
 delete mode 100644 riscv/riscv_asm/build.rs

diff --git a/.vscode/settings.json b/.vscode/settings.json
index 128624e6..174b9a9c 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -30,6 +30,7 @@
     "repr",
     "rgbaf",
     "rgbf",
+    "riscv",
     "rustfmt",
     "serde",
     "stim",
@@ -47,7 +48,7 @@
   "[rust]": {
     "editor.defaultFormatter": "rust-lang.rust-analyzer",
     "editor.formatOnSave": true
-  },
+  }
   //,
   // "rust-analyzer.cargo.unsetTest": [
   //   "syncrim"
@@ -55,4 +56,4 @@
   // "rust-analyzer.cargo.noDefaultFeatures": true,
   // "rust-analyzer.cargo.features": ["gui-egui"]
   // "rust-analyzer.cargo.features": ["components"] # use with nDefaultFeatures to just test
-}
\ No newline at end of file
+}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d9aca9fe..65c682bb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 Tracking changes per date:
 
+## 230731
+
+- RISC-V cross compilation.
+
 ## 230727
 
 - `Signal` type now incorporates formatting. This allows the default formatting to be set on a signal on creation. The data and formatting can be read/written separately by setters/getters.
diff --git a/riscv/asm.s b/riscv/asm.s
index ddc80be7..740830c2 100644
--- a/riscv/asm.s
+++ b/riscv/asm.s
@@ -3,6 +3,7 @@
 start:
     lw x0, 0(x0)
     sw x1, 0(x1)
+l:  beq zero, zero, l
 
 .section .data 
 a:  .byte 0,1,2,3
diff --git a/riscv/riscv_asm/build.rs b/riscv/riscv_asm/build.rs
deleted file mode 100644
index 07dbb579..00000000
--- a/riscv/riscv_asm/build.rs
+++ /dev/null
@@ -1,5 +0,0 @@
-// fn main() {
-//     cc::Build::new().file("foo.c").file("bar.c").compile("foo");
-// }
-
-fn main() {}
diff --git a/src/components/mem.rs b/src/components/mem.rs
index 4bf52ce5..3eed97b8 100644
--- a/src/components/mem.rs
+++ b/src/components/mem.rs
@@ -87,6 +87,7 @@ impl Mem {
         ))
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn rc_new_from_bytes(
         id: &str,
         pos: (f32, f32),