Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failiure on windows #79

Closed
Spooky-Firefox opened this issue Jun 28, 2024 · 6 comments
Closed

Compilation failiure on windows #79

Spooky-Firefox opened this issue Jun 28, 2024 · 6 comments

Comments

@Spooky-Firefox
Copy link
Collaborator

When running cargo run it returns with error

error: could not compile `eframe` (lib) due to 2 previous errors

The cause seem to be unresolved import, winapi winuser.
Version 0.26.2 of Egui seem to have fixed the problem, https://github.com/emilk/egui/releases/tag/0.26.2

Current workaround is to add winapi to cargo toml

winapi = { version = "0.3.9", features = ["winuser"] }
@perlindgren
Copy link
Owner

Did you try updating to 0.26.2?

@perlindgren
Copy link
Owner

As I recall Pawel tried bumping version a while back, but ran into problem that the canvas did not get focus in the editor, thus you could not scroll around. Maybe this problem has been fixed by later versions (if it was a bug) I don't know, or maybe the API has changed so that we are currently missing something.

@perlindgren
Copy link
Owner

(In general, we should to stick to the latest...)

@onsdagens
Copy link
Collaborator

let's do with the workaround for now, do you mind opening a PR for it? i'll keep the issue open until we've bumped egui

@onsdagens
Copy link
Collaborator

we should also look into adding windows and macos runners to the CI

@onsdagens
Copy link
Collaborator

(fixed with #85)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants