Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KJR reinforcement joints ignoring rotation enabled toggle #20

Open
Rodg88 opened this issue Jul 29, 2024 · 2 comments
Open

KJR reinforcement joints ignoring rotation enabled toggle #20

Rodg88 opened this issue Jul 29, 2024 · 2 comments

Comments

@Rodg88
Copy link

Rodg88 commented Jul 29, 2024

BDB has a part using ModuleNodeRotate, however when KJR is also installed, the node gets reinforcement joints added across it even when the rotation is enabled.

Apparently implementing GameEvents.onRoboticPartLockChanged in ModuleBaseRotate should allow KJR to disable it's reinforcing joints automatically when the rotation on a part is enabled.

It may require KSPCF to be installed to work, because it updates that event https://github.com/KSPModdingLibs/KSPCommunityFixes/blob/441f2d7e0ab844cbc3bd86ef2c5410c245f08cb9/KSPCommunityFixes/Modding/DockingPortLockedEvents.cs

This should allow KJR compat with any version of KJR, without having to manually edit the KJR exclusion list.

@siimav
Copy link

siimav commented Jul 29, 2024

To clarify: the onRoboticPartLockChanged event should be fired after the value of IsJointUnlocked() changes. KSPCF isn't required for this mod. All it does is implement this behavior for stock docking port rotation.

@Mjrlun
Copy link

Mjrlun commented Jul 30, 2024

This only applies to Kerbal Joint Reinforcement Continued, and not Kerbal Joint Reinforcement - Next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants