Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement skeleton screens across the board #69

Open
peterzen opened this issue Apr 20, 2020 · 0 comments
Open

Implement skeleton screens across the board #69

peterzen opened this issue Apr 20, 2020 · 0 comments
Labels
enhancement New feature or request frontend
Milestone

Comments

@peterzen
Copy link
Owner

Using https://github.com/buildo/react-placeholder, implement skeleton screens in the top level components.

  • Implement placeholder components for subcomponents (as a rule of thumb, there should be one placeholder for <Card>...</Card> comps, in the same file.
  • Wrap subcomponents with <ReactPlaceholder...>
  • Some components data loading mechanics will have to be changed so that we have a loading prop that can be passed to ReactPlaceholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant