-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a side workspace, similar to those in VSCode and PyCharm, to pgAdmin 4. #7708
Comments
@akshay-joshi I tried out the implementation of this and have a few thoughts to share from the perspective of a user:
There could be a combination that would solve this issue: Simply make the Object Explorer a collapsible pane in the Query Tool workspace. When a user selects the Query Tool workspace, the explorer is closed by default. You would just need a way to signal to the user that it is available to be opened. |
I agree that Drag-and-Drop is not supported in the Workspace layout. Could you please raise a feature request for it? We'll evaluate its feasibility. Additionally, you don’t need to navigate to the Object Explorer to view table structures or column names—you can use the autocomplete feature (CTRL + SPACE) in pgAdmin. We considered making the Object Explorer a collapsible pane in the classic design. However, the Workspace layout is designed as a context-free environment, allowing users to connect to ad-hoc servers that may not be registered in the Object Explorer." |
I have opened #8293. Thanks for considering. |
…nged to get the latest server connection info. pgadmin-org#7708
…nged to get the latest server connection info. pgadmin-org#7708
…nged to get the latest server connection info. pgadmin-org#7708
…et the latest server connection info. #7708
Works fine. |
Firstly well done on producing such a good tool, thanks for all your work on this. However, I don't know who thought hiding the treeview of the database structure while writing queries was a good idea. From the look of the comment above "...similar to those in VSCode and PyCharm" it appears you're copying other designs. It feels like coding "naked" without having a view of the database structure. Ctrl/Space autocomplete is way to slow to be useable. The ideal would be able to see the treeview then be able to click on table/column names, copy them (Ctrl/C), then paste them into the query editor (as per MSSQL Server Management Studio). But I'll stick to v4.8 for now, I really don't like this "workspace" idea without being able to see the database structure. |
Thank you for your review! We truly respect your feedback. This feature was implemented with the following goals in mind:
Regarding the Drag & Drop feature, we have already submitted a feature request. We believe there is always room for improvement. Ultimately, it’s your choice. However, we’ve also provided the flexibility to switch from the 'Workspace' layout to the 'Classic' layout. You can try the latest version and switch to the 'Classic' view if preferred. |
Thank you for all the time and effort you put into the development of pgadmin4! If I may place a request for future releases - please do keep the option to switch into classic layout. It is (for me) a huge time saver not having to switch back and forth between workspaces all the time. One only notices how often one takes a look at the database object tree to make sure the right table, view, field has been selected, when it's no longer there. |
You need to change the preference. Preferences > Miscellaneous > User Interface > Layout, and selecting Classic. |
What a disastrously, awful decision to make this tool far less useful. Please revert this. If people have to go into "Classic" mode to make this useful again then you are moving in the wrong direction. |
First and foremost, just because a few people may not be fond of the Workspace layout, it doesn't mean it's a poor or disastrous decision. Some users appreciate the layout, especially the dedicated space for tools like Query Tool and PSQL. We've also received positive feedback. While we value all input, we can't reverse the work we've invested in over the past three months based on a limited number of opinions. That said, we do respect user feedback, and in response to suggestions, we've made the following adjustments to the Workspace layout: With these changes, the Query Tool and PSQL tabs will now open in the same active workspace where the action is initiated. For example:
Additionally, we've introduced a new preference setting: "Open the Query Tool/PSQL in their respective workspaces". By default, this setting is False. If set to True, it will behave like the v9.0 release, where the Query Tool, PSQL, and Schema Diff tabs will open in their respective workspaces when the Workspace layout is used. This update will provide a more streamlined experience for all users. These changes will be available starting with the v9.1 release scheduled for March 6th. However, if you'd like to try them earlier, you can install the nightly build |
Implement separate workspace for Query Tool, PSQL, Schema Diff, etc.
Attached is the POC work done.
There are a couple of things that we need to check:
SideWorkspace_POC.patch
The text was updated successfully, but these errors were encountered: