Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindBoost.cmake is not compatible with Boost-1.69.0 for cmake-3.30.x #40

Open
Manika-EDB opened this issue Oct 23, 2024 · 3 comments
Open

Comments

@Manika-EDB
Copy link
Contributor

Manika-EDB commented Oct 23, 2024

I tried building pgagent on Windows with Boost-1.69.0 and cmake-3.30.x, but it was not able to detect Boost libraries.
So, I dig into it and here are my findings:

FindBoost.cmake present in <pgagent-source>/cmake is not working for Boost-1.69.0 with cmake-3.30.x.
When I replaced it with the FindBoost.cmake from cmake-3.30.4, it worked fine.
Also, along with this I needed to copy FindPackageHandleStandardArgs.cmake and FindPackageMessage.cmake to <pgagent-source>/cmake/ to make it work.

https://github.com/Kitware/CMake/blob/v3.30.4/Modules/FindBoost.cmake
https://github.com/Kitware/CMake/blob/v3.30.4/Modules/FindPackageHandleStandardArgs.cmake
https://github.com/Kitware/CMake/blob/v3.30.4/Modules/FindPackageMessage.cmake

@dpage
Copy link
Contributor

dpage commented Oct 24, 2024

Can you create a PR to resolve the issue please?

@Manika-EDB
Copy link
Contributor Author

I am not able to push my dev branch to remote. Can you please provide the access to me?

@dpage
Copy link
Contributor

dpage commented Oct 24, 2024

You should create a fork of the repo in your account, and create the dev branch there. Then, create the PR from that to upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants