-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathlog2014_06_16.html
35 lines (35 loc) · 3.35 KB
/
log2014_06_16.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
<!DOCTYPE html>
<html lang='en'>
<head>
<title>
pgmpy Log of 16-06-2014
</title>
<link rel='stylesheet' type='text/css' href='css/bootstrap.min.css' media='screen' />
</head>
<body>
<div class='container'>
<h2>Log of the <code>#pgmpy</code> IRC Channel</h2><br/>
<h3>All the times shown here presently are in Indian Standard Time(IST) +0530Hrs<h3/>
<h3>Date : 16-06-2014 </h3><br/><br/>
<br/>
<kbd>[04:59:37]</kbd> <strong>[connected at Mon Jun 16 04:59:37 2014]</strong><br/>
<kbd>[04:59:51]</kbd> <strong>[I have joined #pgmpy]</strong><br/>
<kbd>[05:02:19]</kbd> <code><navinchandak></code> me: Hi ankur You have been looking at a lot of functions which I am not done with During the last commit, I had to push them because I was updating the PEP of some other functions Please don't look at anything whose docstring is not done.. no docstring/PEP means that I am not done with it<br/>
<kbd>[05:02:27]</kbd> <code><navinchandak></code> Ankur: Okay. Then when should I start reviewing the code.<br/>
<kbd>[05:02:38]</kbd> <code><navinchandak></code> me: (I had mentioned this thing in the commit message) You can look at all code whose docstring is done<br/>
<kbd>[05:02:46]</kbd> <code><navinchandak></code> Ankur: Do you understand that its 1800 lines and if I work the way you are suggesting I will have to go over it twice<br/>
<kbd>[05:02:58]</kbd> <code><navinchandak></code> me: I can send you a list of things which you can see Is that fine? Ankur: When will you be able to finish the whole PR?<br/>
<kbd>[05:03:10]</kbd> <code><navinchandak></code> me: say tomorrow evening Ankur: okay then I will start reviewing the day after tomorrow<br/>
<kbd>[05:03:21]</kbd> <code><navinchandak></code> me: okay fine! Thanks (abinash suggested that when I am working after a PR, then its always advisable to work on a separate branch; I will be doing that from now on) to avoid such problems<br/>
<kbd>[05:03:29]</kbd> <code><navinchandak></code> Ankur: Yeah, working on a different branch for new features would avoid such problems me: Yes. Realized that a bit late :/ I will do that next time onwards<br/>
<kbd>[05:03:36]</kbd> <code><navinchandak></code> Ankur: Also I would suggest to have chats on IRC not here. me: okay. are you usually online on IRC too, when you are online on GChat? Ankur: Yup me: okay. I am copying this conversation on IRC<br/>
<kbd>[05:04:18]</kbd> <code><navinchandak></code> ---------------------------End of conversation -----------------------------<br/>
<kbd>[05:19:50]</kbd> <strong>[disconnected at Mon Jun 16 05:19:50 2014]</strong><br/><kbd>[05:32:06]</kbd> <strong>[I have joined #pgmpy]</strong><br/>
<kbd>[07:43:38]</kbd> <code><abinash_panda></code> ankurankan: any PR from jaspreet yet ?<br/>
<kbd>[16:30:16]</kbd> <strong>[disconnected at Tue Jun 17 16:30:16 2014]</strong><br/>
</div>
<script src='https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js'></script>
<script src='//netdna.bootstrapcdn.com/bootstrap/3.1.1/js/bootstrap.min.js'>
</script>
</body>
</html><br/>