Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Einstein can't run Pre-Production ROM #166

Open
FrankFromPdaSoft opened this issue Apr 6, 2022 · 6 comments
Open

Einstein can't run Pre-Production ROM #166

FrankFromPdaSoft opened this issue Apr 6, 2022 · 6 comments
Assignees

Comments

@FrankFromPdaSoft
Copy link
Collaborator

Currently Einstein only loads ROM files whose CRC value matches expected values. Since a ROM patch changes the CRC value, it can't be loaded. It would be cool, though, if this was possible so that patched ROM files can be tested using Einstein.
To ensure that this option can only be used by people who know exactly what they are doing, the availability of this option should be controlled by something that isn't part of the default setup. This could, for example, be the presence of a particular file in the Einstein directory that the user must create.
This change would probably need to be in the ComputeROMId(KUInt8* inROMPtr) method of the TROMImage.cpp class.

@MatthiasWM
Copy link
Collaborator

It should load the ROM, even if the checksum is not recognised. It checks for the size of the ROM which must still be exactly 8MB. There is another issue though. If the checksum is not recognised, then a bunch of Einstein internal patches are not applied. They are not essential, but they do help Einstein to run smoother. In a patched US ROM, time and date are no longer set, for example.

@MatthiasWM
Copy link
Collaborator

Serach for T_ROM_PATCH if you are interested to see what's being patched.

@FrankFromPdaSoft
Copy link
Collaborator Author

You are right, this was a wrong assumption. Changed ROMs are loaded. What's not loaded is the file from my weird ROM board (https://www.pda-soft.de/weirdromboard.html) although it has the correct size. Einstein doesn't get past the boot sequence. The last I see is this:
image
Right clicks still work, the menu appears, so Einstein itself doesn't seem to be crashed.

@MatthiasWM
Copy link
Collaborator

Please send me a copy. I can check where it gets stuck. Maybe (but unlikely) it's something simple.

@MatthiasWM MatthiasWM changed the title Allow patched ROMs to be run in Einstein Einstein can't run Pre-Production ROM May 31, 2022
@chuma
Copy link
Contributor

chuma commented Oct 18, 2022

Did y'all ever get anywhere with this? I've been doing quite a bit of analysis of the boot sequence of NOS 2.1 lately, I could help.

@MatthiasWM
Copy link
Collaborator

No, we did not follow up on this. Maybe you can ask Frank directly if he wants to share a copy of that early ROM. I don't have the file (or at least I can't find it). As far as I can remember, it was a pre 2.0 with no grayscale. But that's as far as I got.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants