From a85e850542ca2c16a8be753c18cff7d335281483 Mon Sep 17 00:00:00 2001
From: Katherine Thiessen <katherine.thiessen@phac-aspc.gc.ca>
Date: Tue, 14 Jan 2025 13:46:29 -0600
Subject: [PATCH] utilizing the ListFilterComponent to display the value for
 'in' and 'not_in' operators

---
 .../advanced_search/condition.html.erb        |  16 +--
 app/components/advanced_search/condition.rb   |   4 +-
 app/components/advanced_search/group.html.erb |   4 +-
 app/components/advanced_search/value.html.erb |  77 +++++++++++++
 app/components/advanced_search/value.rb       |  13 +++
 .../advanced_search_component.html.erb        | 106 ++++++++++++++++--
 .../controllers/advanced_search_controller.js |  31 ++++-
 .../controllers/list_filter_controller.js     |  14 ++-
 app/models/sample/condition.rb                |   4 +-
 app/models/sample/query.rb                    |  10 +-
 .../advanced_search_group_validator.rb        |   5 +-
 test/system/groups/samples_test.rb            |   2 +-
 12 files changed, 250 insertions(+), 36 deletions(-)
 create mode 100644 app/components/advanced_search/value.html.erb
 create mode 100644 app/components/advanced_search/value.rb

diff --git a/app/components/advanced_search/condition.html.erb b/app/components/advanced_search/condition.html.erb
index ffbcbc5f30..7f1b3aa315 100644
--- a/app/components/advanced_search/condition.html.erb
+++ b/app/components/advanced_search/condition.html.erb
@@ -9,7 +9,7 @@
                            {
                              "aria-label": t("advanced_search_component.field"),
                              class:
-                               "bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-primary-500 focus:border-primary-500 block p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-primary-500 dark:focus:border-primary-500",
+                               "h-10 bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-primary-500 focus:border-primary-500 block p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-primary-500 dark:focus:border-primary-500",
                            } %>
     <%= conditions_form.select :operator,
                            @operations,
@@ -18,15 +18,15 @@
                            },
                            {
                              "aria-label": t("advanced_search_component.operator"),
+                             "data-action": "advanced-search#handleOperatorChange",
                              class:
-                               "bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-primary-500 focus:border-primary-500 block p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-primary-500 dark:focus:border-primary-500",
+                               "h-10 bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-primary-500 focus:border-primary-500 block p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-primary-500 dark:focus:border-primary-500",
                            } %>
-    <%= conditions_form.text_field(
-      :value,
-      placeholder: t("advanced_search_component.value"),
-      "aria-label": t("advanced_search_component.value"),
-      class:
-        "keyInput block py-2.5 px-0 w-full text-sm text-slate-900 bg-transparent border-0 border-b-2 border-slate-300 appearance-none dark:text-white dark:border-slate-600 dark:focus:border-primary-500 focus:outline-none focus:ring-0 focus:border-primary-500 peer",
+    <%= render AdvancedSearch::Value.new(
+      conditions_form: conditions_form,
+      group_index: @group_index,
+      condition: @condition,
+      condition_index: @condition_index,
     ) %>
   <% end %>
   <button
diff --git a/app/components/advanced_search/condition.rb b/app/components/advanced_search/condition.rb
index 32181af000..54c9a2e890 100644
--- a/app/components/advanced_search/condition.rb
+++ b/app/components/advanced_search/condition.rb
@@ -3,9 +3,11 @@
 module AdvancedSearch
   # Component for rendering an advanced search condition
   class Condition < Component
-    def initialize(groups_form:, condition:, fields: [], operations: [])
+    def initialize(groups_form:, group_index:, condition:, condition_index:, fields: [], operations: []) # rubocop:disable Metrics/ParameterLists
       @groups_form = groups_form
+      @group_index = group_index
       @condition = condition
+      @condition_index = condition_index
       @fields = fields
       @operations = operations
     end
diff --git a/app/components/advanced_search/group.html.erb b/app/components/advanced_search/group.html.erb
index 5997297a5c..29812809fd 100644
--- a/app/components/advanced_search/group.html.erb
+++ b/app/components/advanced_search/group.html.erb
@@ -4,10 +4,12 @@
 >
   <div id="group-error-messages-<%= @group_index %>"></div>
   <%= @form.fields_for :groups, @group do |groups_form| %>
-    <% @group.conditions.each do |condition| %>
+    <% @group.conditions.each_with_index do |condition, condition_index| %>
       <%= render AdvancedSearch::Condition.new(
         groups_form: groups_form,
+        group_index: @group_index,
         condition: condition,
+        condition_index: condition_index,
         fields: @fields,
         operations: @operations,
       ) %>
diff --git a/app/components/advanced_search/value.html.erb b/app/components/advanced_search/value.html.erb
new file mode 100644
index 0000000000..0d70fa4270
--- /dev/null
+++ b/app/components/advanced_search/value.html.erb
@@ -0,0 +1,77 @@
+<% if %w[in not_in].any? { |operator| @condition.operator == operator } %>
+  <div
+    data-controller="list-filter"
+    data-list-filter-selection-outlet="#samples-table"
+    data-list-filter-filters-value="<%= @condition.value.present? ? @condition.value.to_s : '[]' %>"
+    class="w-full list-filter value"
+  >
+    <template data-list-filter-target="template">
+      <%= viral_pill(color: :blue, classes: "search-tag inline-flex items-center filter-item mb-1 mr-1 py-1.5") do %>
+        <%= @conditions_form.search_field :value,
+                                      multiple: true,
+                                      class: "hidden",
+                                      data: "turbo-temporary" %>
+        <span class="mr-1 font-mono text-base font-semibold label"></span>
+        <button
+          type="button"
+          class="
+            inline-flex items-center p-1 text-sm bg-transparent rounded-full text-slate-400
+            hover:bg-blue-200 hover:text-blue-900 dark:hover:bg-blue-600
+            dark:hover:text-blue-300
+          "
+          data-action="click->list-filter#remove"
+          aria-label="<%= t(:'components.list_filter.remove_tag') %>"
+        >
+          <%= viral_icon(name: "x_mark", classes: "w-4 h-4") %>
+        </button>
+      <% end %>
+    </template>
+    <div
+      class="
+        relative flex flex-wrap font-mono bg-slate-50 border border-slate-300
+        text-slate-900 text-sm rounded-lg focus-within:ring-primary-500
+        focus-within:border-primary-500 w-full p-2.5 dark:bg-slate-700
+        dark:border-slate-600 dark:placeholder-slate-400 dark:text-white
+        dark:focus-within:ring-primary-500 dark:focus-within:border-primary-500k
+      "
+      data-list-filter-target="tags"
+      data-action="click->list-filter#focus"
+    >
+      <input
+        type="text"
+        name="<%="q[groups_attributes][#{@group_index}][conditions_attributes][#{@condition_index}][value][]"%>"
+        class="bg-transparent border-none focus:outline-none focus:ring-0 grow"
+        autofocus
+        aria-label="<%= t(:'components.list_filter.description') %>"
+        data-action='
+          keydown->list-filter#handleInput
+          paste->list-filter#handlePaste
+          turbo:morph-element->list-filter#idempotentConnect
+        '
+        data-list-filter-target="input"
+      />
+      <button
+        type="button"
+        class="
+          absolute inline-flex items-center justify-center w-5 h-5 text-xs font-bold
+          rounded-full text-slate-600 bg-slate-100 border-3 border-slate-10 bottom-2 end-2
+          dark:text-slate-300 dark:border-slate-900 dark:bg-slate-600
+          dark:hover:bg-slate-500 hover:bg-slate-300
+        "
+        data-action="click->list-filter#clear"
+        aria-label="<%= t(:'components.list_filter.clear') %>"
+        title="<%= t(:'components.list_filter.clear') %>"
+      >
+        <%= viral_icon(name: "x_mark", classes: "h-4 w-4") %>
+      </button>
+    </div>
+  </div>
+<% else %>
+  <%= @conditions_form.text_field(
+    :value,
+    placeholder: t("advanced_search_component.value"),
+    "aria-label": t("advanced_search_component.value"),
+    class:
+      "keyInput block py-2.5 px-0 w-full text-sm text-slate-900 bg-transparent border-0 border-b-2 border-slate-300 appearance-none dark:text-white dark:border-slate-600 dark:focus:border-primary-500 focus:outline-none focus:ring-0 focus:border-primary-500 peer value",
+  ) %>
+<% end %>
diff --git a/app/components/advanced_search/value.rb b/app/components/advanced_search/value.rb
new file mode 100644
index 0000000000..7778e72f21
--- /dev/null
+++ b/app/components/advanced_search/value.rb
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module AdvancedSearch
+  # Component for rendering an advanced search value
+  class Value < Component
+    def initialize(conditions_form:, group_index:, condition:, condition_index:)
+      @conditions_form = conditions_form
+      @group_index = group_index
+      @condition = condition
+      @condition_index = condition_index
+    end
+  end
+end
diff --git a/app/components/advanced_search_component.html.erb b/app/components/advanced_search_component.html.erb
index 1ccc78709f..7bab5c9887 100644
--- a/app/components/advanced_search_component.html.erb
+++ b/app/components/advanced_search_component.html.erb
@@ -1,4 +1,7 @@
-<div data-controller="advanced-search">
+<div
+  data-controller="advanced-search"
+  data-advanced-search-list-filter-outlet=".list-filter"
+>
   <%= viral_dialog(id: 'advanced-search-dialog', size: :large, open: @open) do |dialog| %>
     <%= dialog.with_trigger do %>
       <button
@@ -56,6 +59,94 @@
       <% end %>
     <% end %>
   <% end %>
+  <template data-advanced-search-target="listValueTemplate">
+    <div
+      data-controller="list-filter"
+      data-list-filter-selection-outlet="#samples-table"
+      data-list-filter-filters-value="'[]'"
+      class="w-full list-filter value"
+    >
+      <template data-list-filter-target="template">
+        <%= viral_pill(color: :blue, classes: "search-tag inline-flex items-center filter-item mb-1 mr-1 py-1.5") do %>
+          <input
+            multiple="multiple"
+            class="hidden"
+            data="turbo-temporary"
+            type="search"
+            name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions_attributes][CONDITION_INDEX_PLACEHOLDER][value][]"
+          >
+          <span class="mr-1 font-mono text-base font-semibold label"></span>
+          <button
+            type="button"
+            class="
+              inline-flex items-center p-1 text-sm bg-transparent rounded-full text-slate-400
+              hover:bg-blue-200 hover:text-blue-900 dark:hover:bg-blue-600
+              dark:hover:text-blue-300
+            "
+            data-action="click->list-filter#remove"
+            aria-label="<%= t(:'components.list_filter.remove_tag') %>"
+          >
+            <%= viral_icon(name: "x_mark", classes: "w-4 h-4") %>
+          </button>
+        <% end %>
+      </template>
+      <div
+        class="
+          relative flex flex-wrap font-mono bg-slate-50 border border-slate-300
+          text-slate-900 text-sm rounded-lg focus-within:ring-primary-500
+          focus-within:border-primary-500 w-full p-2.5 dark:bg-slate-700
+          dark:border-slate-600 dark:placeholder-slate-400 dark:text-white
+          dark:focus-within:ring-primary-500 dark:focus-within:border-primary-500k
+        "
+        data-list-filter-target="tags"
+        data-action="click->list-filter#focus"
+      >
+        <input
+          type="text"
+          name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions_attributes][CONDITION_INDEX_PLACEHOLDER][value][]"
+          class="
+            bg-transparent border-none focus:outline-none focus:ring-0 grow
+          "
+          autofocus
+          aria-label="<%= t(:'components.list_filter.description') %>"
+          data-action='
+            keydown->list-filter#handleInput
+            paste->list-filter#handlePaste
+            turbo:morph-element->list-filter#idempotentConnect
+          '
+          data-list-filter-target="input"
+        />
+        <button
+          type="button"
+          class="
+            absolute inline-flex items-center justify-center w-5 h-5 text-xs font-bold
+            rounded-full text-slate-600 bg-slate-100 border-3 border-slate-10 bottom-2 end-2
+            dark:text-slate-300 dark:border-slate-900 dark:bg-slate-600
+            dark:hover:bg-slate-500 hover:bg-slate-300
+          "
+          data-action="click->list-filter#clear"
+          aria-label="<%= t(:'components.list_filter.clear') %>"
+          title="<%= t(:'components.list_filter.clear') %>"
+        >
+          <%= viral_icon(name: "x_mark", classes: "h-4 w-4") %>
+        </button>
+      </div>
+    </div>
+  </template>
+  <template data-advanced-search-target="valueTemplate">
+    <input
+      type="text"
+      name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions_attributes][CONDITION_INDEX_PLACEHOLDER][value]"
+      placeholder="<%= t(".value") %>"
+      aria-label="<%= t(".value") %>"
+      class="
+        keyInput block py-2.5 px-0 w-full text-sm text-slate-900 bg-transparent border-0
+        border-b-2 border-slate-300 appearance-none dark:text-white
+        dark:border-slate-600 dark:focus:border-primary-500 focus:outline-none
+        focus:ring-0 focus:border-primary-500 peer value
+      "
+    />
+  </template>
   <template data-advanced-search-target="conditionTemplate">
     <div
       data-advanced-search-target="conditionsContainer"
@@ -63,13 +154,13 @@
     >
       <select
         class="
-          bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg
+          h-10 bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg
           focus:ring-primary-500 focus:border-primary-500 block p-2.5 dark:bg-gray-700
           dark:border-gray-600 dark:placeholder-gray-400 dark:text-white
           dark:focus:ring-primary-500 dark:focus:border-primary-500
         "
         aria-label="<%= t(".field") %>"
-        name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions][CONDITION_INDEX_PLACEHOLDER][field]"
+        name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions_attributes][CONDITION_INDEX_PLACEHOLDER][field]"
       >
         <option selected><%= t(".field") %></option>
         <% @fields.each do |field| %>
@@ -78,13 +169,14 @@
       </select>
       <select
         class="
-          bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg
+          h-10 bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg
           focus:ring-primary-500 focus:border-primary-500 block p-2.5 dark:bg-gray-700
           dark:border-gray-600 dark:placeholder-gray-400 dark:text-white
           dark:focus:ring-primary-500 dark:focus:border-primary-500
         "
         aria-label="<%= t(".operator") %>"
-        name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions][CONDITION_INDEX_PLACEHOLDER][operator]"
+        data-action="advanced-search#handleOperatorChange"
+        name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions_attributes][CONDITION_INDEX_PLACEHOLDER][operator]"
       >
         <option selected><%= t(".operator") %></option>
         <% @operations.each do |operation| %>
@@ -93,14 +185,14 @@
       </select>
       <input
         type="text"
-        name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions][CONDITION_INDEX_PLACEHOLDER][value]"
+        name="q[groups_attributes][GROUP_INDEX_PLACEHOLDER][conditions_attributes][CONDITION_INDEX_PLACEHOLDER][value]"
         placeholder="<%= t(".value") %>"
         aria-label="<%= t(".value") %>"
         class="
           keyInput block py-2.5 px-0 w-full text-sm text-slate-900 bg-transparent border-0
           border-b-2 border-slate-300 appearance-none dark:text-white
           dark:border-slate-600 dark:focus:border-primary-500 focus:outline-none
-          focus:ring-0 focus:border-primary-500 peer
+          focus:ring-0 focus:border-primary-500 peer value
         "
       />
       <button
diff --git a/app/javascript/controllers/advanced_search_controller.js b/app/javascript/controllers/advanced_search_controller.js
index f46b08fe4f..af0f82f93d 100644
--- a/app/javascript/controllers/advanced_search_controller.js
+++ b/app/javascript/controllers/advanced_search_controller.js
@@ -6,11 +6,18 @@ export default class extends Controller {
     "conditionTemplate",
     "groupsContainer",
     "groupTemplate",
+    "valueTemplate",
+    "listValueTemplate",
   ];
+  static outlets = ["list-filter"];
 
   connect() {}
 
-  idempotentConnect() {}
+  idempotentConnect() {
+    this.listFilterOutlets.forEach((outlet) => {
+      outlet.idempotentConnect();
+    });
+  }
 
   addCondition(event) {
     let group = event.currentTarget.parentElement.closest(
@@ -108,4 +115,26 @@ export default class extends Controller {
       }
     });
   }
+
+  handleOperatorChange(event) {
+    let operator = event.target.value;
+    let condition = event.target.parentElement;
+    let value = condition.querySelector(".value");
+    let group = condition.parentElement;
+    let group_index = this.groupsContainerTargets.indexOf(group);
+    let condition_index =
+      group.querySelectorAll(
+        "div[data-advanced-search-target='conditionsContainer']",
+      ).length - 1;
+
+    if (["in", "not_in"].includes(operator)) {
+      value.outerHTML = this.listValueTemplateTarget.innerHTML
+        .replace(/GROUP_INDEX_PLACEHOLDER/g, group_index)
+        .replace(/CONDITION_INDEX_PLACEHOLDER/g, condition_index);
+    } else {
+      value.outerHTML = this.valueTemplateTarget.innerHTML
+        .replace(/GROUP_INDEX_PLACEHOLDER/g, group_index)
+        .replace(/CONDITION_INDEX_PLACEHOLDER/g, condition_index);
+    }
+  }
 }
diff --git a/app/javascript/controllers/list_filter_controller.js b/app/javascript/controllers/list_filter_controller.js
index 0ede3f35e3..b49770682e 100644
--- a/app/javascript/controllers/list_filter_controller.js
+++ b/app/javascript/controllers/list_filter_controller.js
@@ -127,11 +127,13 @@ export default class extends Controller {
   }
 
   #updateCount() {
-    const count = this.filtersValue.filter(
-      (sample) => sample.length > 0,
-    ).length;
-    this.countTarget.innerText = count;
-    this.countTarget.classList.toggle("hidden", count === 0);
-    this.countTarget.classList.toggle("inline-flex", count > 0);
+    if (this.hasCountTarget) {
+      const count = this.filtersValue.filter(
+        (sample) => sample.length > 0,
+      ).length;
+      this.countTarget.innerText = count;
+      this.countTarget.classList.toggle("hidden", count === 0);
+      this.countTarget.classList.toggle("inline-flex", count > 0);
+    }
   }
 }
diff --git a/app/models/sample/condition.rb b/app/models/sample/condition.rb
index 8dd589e29f..4d87a72c4c 100644
--- a/app/models/sample/condition.rb
+++ b/app/models/sample/condition.rb
@@ -7,11 +7,11 @@ class Sample::Condition # rubocop:disable Style/ClassAndModuleChildren
 
   attribute :field, :string
   attribute :operator, :string
-  attribute :value, :string
+  attribute :value
 
   validates :operator, inclusion: { in: %w[= != <= >= contains in not_in] }
 
   def empty?
-    field.empty? && operator.empty? && value.empty?
+    field.empty? && operator.empty? && ((value.is_a?(Array) && value.compact!.nil?) || value.empty?)
   end
 end
diff --git a/app/models/sample/query.rb b/app/models/sample/query.rb
index 6bcb3a599e..8055d0a81b 100644
--- a/app/models/sample/query.rb
+++ b/app/models/sample/query.rb
@@ -108,15 +108,15 @@ def searchkick_kwargs
       includes: [project: { namespace: [{ parent: :route }, :route] }] }
   end
 
-  def advanced_search_params # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize
+  def advanced_search_params # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
     or_conditions = []
     groups.each do |group|
       and_conditions = {}
       group.conditions.map do |condition|
         case condition.operator
-        when '='
+        when '=', 'in'
           and_conditions[condition.field] = condition.value
-        when '!='
+        when '!=', 'not_in'
           and_conditions[condition.field] = { not: condition.value }
         when '<='
           between_condition(and_conditions, condition, :lte)
@@ -124,10 +124,6 @@ def advanced_search_params # rubocop:disable Metrics/MethodLength, Metrics/Cyclo
           between_condition(and_conditions, condition, :gte)
         when 'contains'
           and_conditions[condition.field] = { ilike: "%#{condition.value}%" }
-        when 'in'
-          and_conditions[condition.field] = condition.value.split(/,\s|,/)
-        when 'not_in'
-          and_conditions[condition.field] = { not: condition.value.split(/,\s|,/) }
         end
       end
       or_conditions << and_conditions
diff --git a/app/validators/advanced_search_group_validator.rb b/app/validators/advanced_search_group_validator.rb
index 7dba352d47..1b26574d9d 100644
--- a/app/validators/advanced_search_group_validator.rb
+++ b/app/validators/advanced_search_group_validator.rb
@@ -19,10 +19,11 @@ def validate(record)
 
   private
 
-  def empty_search?(record) # rubocop:disable Metrics/AbcSize
+  def empty_search?(record) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
     if record.groups.length == 1 && record.groups[0].conditions.length == 1 &&
        record.groups[0].conditions[0].field.blank? && record.groups[0].conditions[0].operator.blank? &&
-       record.groups[0].conditions[0].value.blank?
+       ((record.groups[0].conditions[0].value.is_a?(Array) && record.groups[0].conditions[0].value.compact!.blank?) ||
+       record.groups[0].conditions[0].value.blank?)
       return true
     end
 
diff --git a/test/system/groups/samples_test.rb b/test/system/groups/samples_test.rb
index 6acbe295c1..485f7f3b37 100644
--- a/test/system/groups/samples_test.rb
+++ b/test/system/groups/samples_test.rb
@@ -452,7 +452,7 @@ def retrieve_puids
           within all("div[data-advanced-search-target='conditionsContainer']")[0] do
             find("select[name$='[field]']").find("option[value='puid']").select_option
             find("select[name$='[operator]']").find("option[value='in']").select_option
-            find("input[name$='[value]']").fill_in with: "#{@sample1.puid}, #{@sample2.puid}"
+            find("input[name$='[value][]']").fill_in with: "#{@sample1.puid}, #{@sample2.puid}"
           end
         end
         click_button I18n.t(:'advanced_search_component.apply_filter_button')