Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when removing pkg that doesn't exist #781

Closed
aclark02-arcus opened this issue May 31, 2024 · 2 comments
Closed

App crashes when removing pkg that doesn't exist #781

aclark02-arcus opened this issue May 31, 2024 · 2 comments
Assignees

Comments

@aclark02-arcus
Copy link
Collaborator

Just noticed that if you click the big blue button to remove a package from the db, it will crash the app. This happens when:

  • the field is empty (as seen below)
  • the field is not empty, but the package doesn't exist. For example, removing "shiny" when "shiny" doesn't exist. Notice, the auto-complete won't work (obvi) since the package doesn't exist, but the user can still type anything they want here. I only noticed it because I accidently clicked the blue button twice really fast when removing a package, and the text still existed.

image

Console output:
image

@narayanan-iyer-pfizer
Copy link
Collaborator

I'm not able to replicate this

@aclark02-arcus
Copy link
Collaborator Author

Hi @narayanan-iyer-pfizer, this was fixed with #782. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants