Review of {admiraldev} Developer Guide pages ahead of 1.0 #2183
Replies: 13 comments 44 replies
-
Development Process page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
Programming Strategy page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
Writing Vignettes page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
Unit Test Guidance page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
Guidance for git and github usage page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
PR Review guidance page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
R CMD Issues page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
Release strategy page - list your comments below. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
Package Extensions page - list your comments below. |
Beta Was this translation helpful? Give feedback.
-
Admiral Manifesto Revisited |
Beta Was this translation helpful? Give feedback.
-
Good discussions team! Adding some high level thoughts in case useful here @bms63 and @manciniedoardo - overall i think a lot of work could potentially be created here updating these pages but i would focus on value updates here (e.g. where our dev process has changed like git branching strategy) rather than an overhaul given that i expect we shouldn't need as many new community contributors compared to when we were first building up this package. also there was a few mention of removing some pages that gave more generic guidance such as unit testing - i get that as they're not related specifically to admiral and maybe one day we'd move these to some higher level pharmaverse location, but fyi i have been sharing these with other pharmaverse pkg dev teams like datacutr and sdtmchecks. people have found them really useful, so i'd be in favour of not removing any content for now and down the line if we find a better place to store it then we could move. p.s. tag me in any reply if you'd like my further input, as i won't ask for notifications on this thread for fear of an already busy inbox exploding 😄 |
Beta Was this translation helpful? Give feedback.
-
Revamp of admiraltemplate |
Beta Was this translation helpful? Give feedback.
-
Please share your thoughts about what should be enhanced/modified/removed ahead of 1.0.
Beta Was this translation helpful? Give feedback.
All reactions