Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Unify *joined* functions #2126

Closed
bundfussr opened this issue Sep 25, 2023 · 0 comments · Fixed by #2163 or #2237
Closed

Feature Request: Unify *joined* functions #2126

bundfussr opened this issue Sep 25, 2023 · 0 comments · Fixed by #2163 or #2237
Assignees
@bundfussr
Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming

Comments

@bundfussr
Copy link
Collaborator

Feature Idea

The arguments and behavior of the *joined* functions should be unified:

derive_vars_joined( 
  dataset, 
  dataset_add, 
  by_vars = NULL, 
  order = NULL, 
  new_vars = NULL, 
  tmp_obs_nr_var = NULL, 
  join_vars = NULL, # do we need this argument? 
  join_type, 
  filter_add = NULL, 
  first_cond_lower = NULL, 
  first_cond_upper = NULL, 
  filter_join = NULL, 
  mode = NULL, 
  exist_flag = NULL, 
  true_value = "Y", 
  false_value = NA_character_, 
  missing_values = NULL, 
  check_type = "warning"
) 

derive_var_joined_exist_flag( 
  dataset, 
  dataset_add, 
  by_vars, 
  order, 
  new_var, 
  tmp_obs_nr_var = NULL, 
  join_vars, 
  join_type, 
  filter_add, 
  first_cond_lower = NULL, 
  first_cond_upper = NULL, 
  filter_join, 
  true_value = "Y", 
  false_value = NA_character_, 
  missing_value = NA_character_,? 
  check_type = "warning"
)

Note: filter_joined() should be updated accordingly.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@bundfussr bundfussr added enhancement New feature or request programming function re-work issues identified by function re-work gang - usually argument alignment, user friendliness release Q4-2023 labels Sep 25, 2023
@bundfussr bundfussr self-assigned this Sep 25, 2023
@bundfussr bundfussr moved this from Priority to In Progress in admiral (sdtm/adam, dev, ci, template, core) Sep 29, 2023
bundfussr added a commit that referenced this issue Sep 29, 2023
@bundfussr
#2126 unify_joined: update arguments and tests of filter_joined() and…
93d50dc 
… derive_var_joined_exist_flag()
bundfussr added a commit that referenced this issue Oct 10, 2023
@bundfussr
#2126 unify_joined: update examples for derive_var_joined_exist_flag()
0a1e272
bundfussr added a commit that referenced this issue Oct 11, 2023
@bundfussr
#2126 unify_joined: documentation of filter_joined() and derive_var_j…
b30339e 
…oined_exist_flag()
@bundfussr bundfussr linked a pull request Oct 11, 2023 that will close this issue
Closes #2126 unify_joined: update derive_vars_joined(), derive_var_joined_exist_flag(), filter_joined() #2163
Merged
14 tasks
bundfussr added a commit that referenced this issue Oct 13, 2023
@bundfussr
#2126 unify_joined: update derive_vars_joined()
85c98ff
bundfussr added a commit that referenced this issue Oct 13, 2023
@bundfussr
#2126 unify_joined: add get_joined_data(), update derive_extreme_even…
3f58b4d 
…t(), add tests
bundfussr added a commit that referenced this issue Oct 16, 2023
@bundfussr
#2126 unify_joined: update templates
3802969
bundfussr added a commit that referenced this issue Oct 16, 2023
@bundfussr
#2126 unify_joined: style files
5b20848
bundfussr added a commit that referenced this issue Oct 16, 2023
@bundfussr
#2126 unify_joined: update vignettes
20e19fe
bundfussr added a commit that referenced this issue Oct 17, 2023
@bundfussr
#2126 unify_joined: update vignettes
54ba034
bundfussr added a commit that referenced this issue Oct 17, 2023
@bundfussr
#2126 unify_joined: style files
ab7e06b
bundfussr added a commit that referenced this issue Oct 17, 2023
@bundfussr
#2126 unify_joined: style files
09ac3f7
bundfussr added a commit that referenced this issue Oct 17, 2023
@bundfussr
#2126 unify_joined: remove commented out code
bc056b3
bundfussr added a commit that referenced this issue Oct 17, 2023
@bundfussr
#2126 unify_joined: fix lintr issues
e412c79
bundfussr added a commit that referenced this issue Oct 17, 2023
@bundfussr
#2126 unify_joined: add example for first_cond_lower
bdf0232
bundfussr added a commit that referenced this issue Oct 19, 2023
@bundfussr
#2126 unify_joined: update function documentation
81d641f
bundfussr added a commit that referenced this issue Oct 19, 2023
@bundfussr
#2126 unify_joined: style files
7fbbdee
bundfussr added a commit that referenced this issue Oct 19, 2023
@bundfussr
#2126 unify_joined: style files
cf59e6f
bundfussr added a commit that referenced this issue Oct 19, 2023
@bundfussr
#2126 unify_joined: update NEWS.md
1fec673
bundfussr added a commit that referenced this issue Oct 20, 2023
@bundfussr
#2126 unify_joined: improve documentation
770cd02
bundfussr added a commit that referenced this issue Oct 20, 2023
@bundfussr
#2126 unify_joined: add example to event_joined()
6c3aabb
bundfussr added a commit that referenced this issue Oct 20, 2023
@bundfussr
#2126 unify_joined: fix R-CMD check
2094c69
bundfussr added a commit that referenced this issue Oct 20, 2023
@bundfussr
#2126 unify_joined: check class of deprecation warning
c18279f
@bundfussr bundfussr moved this from In Progress to In Review in admiral (sdtm/adam, dev, ci, template, core) Oct 20, 2023
bundfussr added a commit that referenced this issue Oct 31, 2023
@bundfussr
#2126 unify_joined: improve documentation
69cb1ca
bundfussr pushed a commit that referenced this issue Nov 2, 2023
@jerryekohe
#2126 unify_joined: style files
11f572b
bundfussr pushed a commit that referenced this issue Nov 6, 2023
@jerryekohe
#2126 unify_joined: clean up globals.R
051a51d
bundfussr pushed a commit that referenced this issue Nov 6, 2023
@jerryekohe
#2126 unify_joined: improve documentation
59f303b
bms63 added a commit that referenced this issue Nov 6, 2023
@bundfussr @jerryekohe @bms63
Closes #2126 unify_joined: update derive_vars_joined(), derive_var_jo…
5a0f7ed 
…ined_exist_flag(), filter_joined() (#2163)

* #2126 unify_joined: update arguments and tests of filter_joined() and derive_var_joined_exist_flag()

* #2126 unify_joined: update examples for derive_var_joined_exist_flag()

* #2126 unify_joined: documentation of filter_joined() and derive_var_joined_exist_flag()

* #2126 unify_joined: update derive_vars_joined()

* #2126 unify_joined: add get_joined_data(), update derive_extreme_event(), add tests

* #2126 unify_joined: update templates

* #2126 unify_joined: style files

* #2126 unify_joined: update vignettes

* #2126 unify_joined: update vignettes

* #2126 unify_joined: style files

* #2126 unify_joined: style files

* #2126 unify_joined: remove commented out code

* #2126 unify_joined: fix lintr issues

* #2126 unify_joined: add example for first_cond_lower

* #2126 unify_joined: update function documentation

* #2126 unify_joined: style files

* #2126 unify_joined: style files

* #2126 unify_joined: update NEWS.md

* #2126 unify_joined: improve documentation

* #2126 unify_joined: add example to event_joined()

* #2126 unify_joined: fix R-CMD check

* #2126 unify_joined: check class of deprecation warning

* #2126 unify_joined: improve documentation

* #2126 unify_joined: style files

* #2126 unify_joined: clean up globals.R

* #2126 unify_joined: improve documentation

---------

Co-authored-by: Jerry Johnson <[email protected]>
Co-authored-by: Ben Straub <[email protected]>
bundfussr added a commit that referenced this issue Nov 16, 2023
@bundfussr
#2126 unify_joined: remove too extensive documentation
ed51929
@bundfussr bundfussr linked a pull request Nov 16, 2023 that will close this issue
Closes #2126 unify_joined: Remove too extensive documentation #2237
Merged
14 tasks
@bundfussr bundfussr reopened this Nov 16, 2023
@bundfussr bundfussr moved this from Priority to In Review in admiral (sdtm/adam, dev, ci, template, core) Nov 16, 2023
bms63 added a commit that referenced this issue Nov 20, 2023
@bundfussr @jerryekohe @bms63
Closes #2126 unify_joined: Remove too extensive documentation (#2237)
f9fd467 
* #2126 unify_joined: update arguments and tests of filter_joined() and derive_var_joined_exist_flag()

* #2126 unify_joined: update examples for derive_var_joined_exist_flag()

* #2126 unify_joined: documentation of filter_joined() and derive_var_joined_exist_flag()

* #2126 unify_joined: update derive_vars_joined()

* #2126 unify_joined: add get_joined_data(), update derive_extreme_event(), add tests

* #2126 unify_joined: update templates

* #2126 unify_joined: style files

* #2126 unify_joined: update vignettes

* #2126 unify_joined: update vignettes

* #2126 unify_joined: style files

* #2126 unify_joined: style files

* #2126 unify_joined: remove commented out code

* #2126 unify_joined: fix lintr issues

* #2126 unify_joined: add example for first_cond_lower

* #2126 unify_joined: update function documentation

* #2126 unify_joined: style files

* #2126 unify_joined: style files

* #2126 unify_joined: update NEWS.md

* #2126 unify_joined: improve documentation

* #2126 unify_joined: add example to event_joined()

* #2126 unify_joined: fix R-CMD check

* #2126 unify_joined: check class of deprecation warning

* #2126 unify_joined: improve documentation

* #2126 unify_joined: style files

* #2126 unify_joined: clean up globals.R

* #2126 unify_joined: improve documentation

* #2126 unify_joined: remove too extensive documentation

---------

Co-authored-by: Jerry Johnson <[email protected]>
Co-authored-by: Ben Straub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bundfussr bundfussr

Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
1 participant
@bundfussr