Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 1.2 goes out into the wild 😱 #2635

Closed
bms63 opened this issue Jan 11, 2025 · 9 comments · Fixed by #2641
Closed

Release: 1.2 goes out into the wild 😱 #2635

bms63 opened this issue Jan 11, 2025 · 9 comments · Fixed by #2641

Comments

@bms63
Copy link
Collaborator

bms63 commented Jan 11, 2025

Background Information

Follow these steps to complete Release Checks: #2394

Definition of Done

admiral is up on CRAN and no one yells at me.

@bms63
Copy link
Collaborator Author

bms63 commented Jan 14, 2025

@millerg23 we ever discover a better way to link the DAIDs stuff?
image

@bms63
Copy link
Collaborator Author

bms63 commented Jan 14, 2025

CRAN lets these slide through last few times, but never know when it will become a problem

@bms63
Copy link
Collaborator Author

bms63 commented Jan 14, 2025

Maybe we should just store a copy of DAIDs pdf in our repo and link that? tell users this is available but to make sure it is latest by going to nih website??

bms63 added a commit that referenced this issue Jan 14, 2025
@bundfussr
Copy link
Collaborator

Maybe we should just store a copy of DAIDs pdf in our repo and link that? tell users this is available but to make sure it is latest by going to nih website??

Where come these errors from? All CI/CD checks pass and the link works (at least for me).

@bms63
Copy link
Collaborator Author

bms63 commented Jan 14, 2025

Maybe we should just store a copy of DAIDs pdf in our repo and link that? tell users this is available but to make sure it is latest by going to nih website??

Where come these errors from? All CI/CD checks pass and the link works (at least for me).

use urlchecker::url_check() this is what CRAN uses

@bundfussr
Copy link
Collaborator

Maybe we should just store a copy of DAIDs pdf in our repo and link that? tell users this is available but to make sure it is latest by going to nih website??

Where come these errors from? All CI/CD checks pass and the link works (at least for me).

use urlchecker::url_check() this is what CRAN uses

I see.

As the link works and CRAN accepted it before, I wouldn't change anything.

@bms63
Copy link
Collaborator Author

bms63 commented Jan 14, 2025

should we at least update the link?
image

@bundfussr
Copy link
Collaborator

should we at least update the link? image

Yes, of course.

I tried only the links in the "Lab Grading" vignette and these worked for me.

bms63 added a commit that referenced this issue Jan 14, 2025
@bms63
Copy link
Collaborator Author

bms63 commented Jan 14, 2025

should we at least update the link? image

Yes, of course.

I tried only the links in the "Lab Grading" vignette and these worked for me.

actually all the links work - just get 403s for them in the urlchecker. no update needed

bms63 added a commit that referenced this issue Jan 14, 2025
bms63 added a commit that referenced this issue Jan 14, 2025
bms63 added a commit that referenced this issue Jan 15, 2025
bms63 added a commit that referenced this issue Jan 15, 2025
bms63 added a commit that referenced this issue Jan 15, 2025
* fix: #2635 wordsmith news; upversion to R 4.1; release schedule udpated; non-ascii characters removed

* fix: #2635 broken links

* docs: faqs link to discovery; removed remotes;

* fix: #2635 keep remotes until last possible second!

* fix: revert admiraldev to dev version

* chore: #2635 spelling

* chore: #2635 moved get_summary entry to dep section

* chore: #2635 little bit of wordsmithing

* chore: #2635 new ackno

* docs: #2635 dev versions removed

* chore: #2635 removed remotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants