Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with insufficient memory on large projects #1095

Open
adso023 opened this issue Nov 21, 2022 · 1 comment
Open

Fails with insufficient memory on large projects #1095

adso023 opened this issue Nov 21, 2022 · 1 comment

Comments

@adso023
Copy link

adso023 commented Nov 21, 2022

Describe the bug

  • On large projects betterer fails out with a NodeJS heap out of memory exception.
  • I realize we can increase the node heap size but we're essentially maxing out a Github actions runner so we don't have much room left to run this in CI.

To Reproduce
Repo: https://github.com/adso023/Dummy-Repository
Command: yarn run betterer

// .betterer.ts
import { eslint } from '@betterer/eslint';
const eslintConfig = require('./.eslintrc.js');

export default {
  'ts lint': eslint(eslintConfig.overrides[0].rules).include(['src/**/*.ts']),
};

Expected behavior
betterer should run correctly and it shouldn't error out due to insufficient memory

Screenshots
image

Versions (please complete the following information):

  • OS: Windows 10 1809
  • Betterer: 4.4.1
  • Node: v14.17.0

Additional context
It seems like this might be a similar issue to #1050, though we're running into memory issues rather than raw file count. It seems like from the comments in that ticket that betterer keeps each file open, is there any reason for this because it seems like closing files once parsed should solve both these issues.

@alexseguin
Copy link

Bump, also have this issue on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants