Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary/secondary mass labels have inappropriate maxWidth #149

Closed
arouinfar opened this issue Mar 14, 2023 · 2 comments
Closed

Primary/secondary mass labels have inappropriate maxWidth #149

arouinfar opened this issue Mar 14, 2023 · 2 comments
Assignees
@jonathanolson
Labels
type:i18n

Comments

@arouinfar
Copy link
Contributor

Discovered when reviewing dynamic layout/strings in #145.

The primary/secondary masses on the Intro screen do not gracefully handle dynamic strings.
image

Looks like these labels need a more appropriate maxWidth so they don't escape the bounds of the background rectangle. @jonathanolson can you reduce the maxWidth so that the string remains within bounds?
@arouinfar
Copy link
Contributor Author

Tagging for #150

@arouinfar
Copy link
Contributor Author

The behavior on master seems to be okay now, so I'm going to close.
image

If I see the issue happening again, I'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @arouinfar