-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
massNumberProperty
and numberControlVolumeProperty
need units and consistent names
#155
Comments
Added units to the intermediate Properties above. |
Discussed with @jonathanolson and @DianaTavares The intermediary properties are necessary to the internal workings of the sim, so this is a big ask. Instead, we decided to consistently name these properties, |
Renaming done above, can you verify? |
Also, should I uninstrument those? |
massNumberProperty
and numberControlVolumeProperty
massNumberProperty
and numberControlVolumeProperty
need units and consistent names
@jonathanolson the updated names and units look good, thanks.
From our discussion, it sounded like they were necessary to the internal workings of the sim. Rather than uninstrument, we decided to consistently name these properties and provide them with the correct units. Closing. |
For #150
On the Intro Screen, the Mass NumberControl has an internal
massNumberProperty
. I decided to unfeature it in #137 because It is identical to themassProperty
found in the model. The only usage ofmassNumberProperty
seems to be a dependency for thenumberDisplay.valueText
.I don't think
massNumberProperty
ormassNumberControl.numberDisplay.valueText
add any real value. We use the same mass units in the model and the view. Can these be uninstrumented @jonathanolson?Similarly, the Volume NumberControl has an associated
numberControlVolumeProperty
which appears to be the volume in liters, though its units are null. The only usage ofnumberControlVolumeProperty
that I can find is a dependency of the associatednumberDisplay.valueText
. However, this seems like an odd way to give clients access to the volume in liters. The method indensity.compareScreen.view.volumeNumberControl.numberDisplay.valueText.stringProperty
is preferable.@jonathanolson can we instrument
numberControlVolumeProperty
and use the Compare Screen method to display the NumberDisplay contents?The text was updated successfully, but these errors were encountered: