Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update customDensityProperty.rangeProperty #157

Closed
arouinfar opened this issue Mar 27, 2023 · 2 comments
Closed

Update customDensityProperty.rangeProperty #157

arouinfar opened this issue Mar 27, 2023 · 2 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

For #150

On the Mystery screen, the blocks have a customDensityProperty that can be used to directly set the density of the block. The range is currently 0-infinity, which exceeds what is pedagogically useful. Extreme densities can also create difficulties for the physics engine (e.g. very dense blocks are difficult to pick up off the ground).

@DianaTavares @jonathanolson and I discussed today, and decided that we should limit the density to something more realistic. A reasonable minimum would be the density of styrofoam, 150 kg/m^3. A reasonable maximum would be something similar to gold (the highest density listed in the table).

The densest naturally occurring element is osmium, with a density of 22590 kg/m^3. I tested in master with 10L block at 23000 kg/m^3 and the performance seemed reasonable. This slightly exceeds the density of gold, but I think it is pedagogically valuable.

@jonathanolson let's set the range to 150-23000 kg/m^3.

jonathanolson added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 30, 2023
@jonathanolson
Copy link
Contributor

Handled in the commit above. @arouinfar can you verify?

@arouinfar
Copy link
Contributor Author

Looks good in master, thanks @jonathanolson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants