Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable CT tests for PhET-iO #12

Closed
pixelzoom opened this issue Nov 13, 2020 · 3 comments
Closed

enable CT tests for PhET-iO #12

pixelzoom opened this issue Nov 13, 2020 · 3 comments
Labels
dev:phet-io priority:5-deferred

Comments

@pixelzoom
Copy link
Contributor

For https://github.com/phetsims/phet-io/issues/1715#issuecomment-725677102, and to support incremental development...

I enabled phet-io (so that I can test with phetmarks) but disabled validation (so I won't get CT failures).

When the sim's phet-io implementation is more mature, validation should be turned on, by removing phet.phet-io.validation: false from package.json. Deferred until that time.
pixelzoom referenced this issue Nov 13, 2020
@pixelzoom
enabled phet-io without validation for fourier, phetsims/phet-io#1715
9be61da
@pixelzoom
Copy link
Contributor Author

So that CT doesn't run State wrapper tests, I've added fourier-making-waves to perennial/data/phet-io-state-unsupported. We'll need to remember to remove it from this file when we want PhET-iO testing to resume.

I'd prefer a way to disable all PhET-iO CT tests, but that's not currently possible. See phetsims/aqua#113.

@pixelzoom pixelzoom changed the title enable PhET-iO validation in package.json enable PhET-iO tests in CT Dec 13, 2020
@pixelzoom pixelzoom mentioned this issue Dec 13, 2020
Open
@pixelzoom pixelzoom changed the title enable PhET-iO tests in CT enable CT tests for PhET-iO Dec 13, 2020
pixelzoom referenced this issue in phetsims/perennial Dec 13, 2020
@pixelzoom
add fourier-making-waves to phet-io-state-unsupported, phetsims/aqua#113
1d60657
@pixelzoom pixelzoom self-assigned this Apr 1, 2022
pixelzoom added a commit that referenced this issue Apr 5, 2022
@pixelzoom
rename SeriesType enm to 'SIN' and 'COS', instrument SeriesTypeRadioB…
8cf3971 
…uttonGroup, #12
@pixelzoom
Copy link
Contributor Author

I considered enabling these tests now, to keep problems from creeping into Fourier. But fuzz testing the State wrapper locally, I ran into (at least) 2 problems, see #220 and #221. So deferring this again. I'm not going to enable CT tests until things are looking good locally.

@pixelzoom pixelzoom removed their assignment Apr 5, 2022
@pixelzoom
Copy link
Contributor Author

I moved this task to #234. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:phet-io priority:5-deferred
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom