Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand TemperatureDescriber's capabilities or narrow its scope #118

Open
jbphet opened this issue Dec 17, 2021 · 2 comments
Open

Expand TemperatureDescriber's capabilities or narrow its scope #118

jbphet opened this issue Dec 17, 2021 · 2 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Dec 17, 2021

While working on the Layer Model screen, I found that I needed to add support for ground temperature values below the previously established minimum. This is mostly done, and about to be committed, but the code in TemperatureDescriber is now defining a value for the range that is only applicable to the first two screens.

@jessegreenberg - I'm not sure whether it would be best to narrow the scope of this, perhaps calling it LandscapeTemperatureDescriber, or generalizing it to work for arbitrary temperature ranges. What do you think?

@jbphet
Copy link
Contributor Author

jbphet commented May 15, 2023

Deferring until description becomes a priority again.

@jbphet
Copy link
Contributor Author

jbphet commented Nov 3, 2023

Undeferring since the description feature is a priority for this iteration. Assigning to @jessegreenberg to respond to the question raised in the initial comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants