Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the sound files are larger than they probably need to be #198

Open
jbphet opened this issue Apr 20, 2021 · 5 comments
Open

Some of the sound files are larger than they probably need to be #198

jbphet opened this issue Apr 20, 2021 · 5 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Apr 20, 2021

While working on the soundboard (see phetsims/phetmarks#45), I noticed that the slow-motion rotation sounds are very long. I suspected that this means that the files are also quite large, and indeed they are. According to Windows Explorer, the size for both rotation-counterclockwise-slow-motion.mp3 and rotation-clockwise-slow-motion.mp3 is is 303 KB. The lengths of these loops could probably be reduced quite a bit without compromising the user experience. This would reduce the size of the download for this sim, as well as the startup time.

I'm thinking I should go ahead and do this, since we are going to be consolidating this code into the greenhouse-effect fairly soon.

@jbphet
Copy link
Contributor Author

jbphet commented Apr 20, 2021

Note to self: Remember to benchmark the sim size and startup time before and after making the changes to these files.

@jbphet jbphet self-assigned this Apr 20, 2021
@jbphet jbphet transferred this issue from phetsims/molecules-and-light Jul 29, 2022
@jbphet
Copy link
Contributor Author

jbphet commented Jul 29, 2022

Transferred this issue from molecules-and-light to greenhouse-effect, since that's where the sound files now reside.

I'm also going to mark this as "blocks-publication", since this should be addressed before the next publication of the Molecules and Light sim or any version of Greenhouse Effect that includes these sounds.

@zepumph
Copy link
Member

zepumph commented Oct 20, 2022

I would recommend this as a "blocks-sim-publication", and creating a "pointer" issue if needed in Molecules and Light because otherwise every dev will see this issue when going to publish any sim (like I just did for getting ready for Friction and Ratio and Proportion).

@jbphet
Copy link
Contributor Author

jbphet commented Jul 19, 2023

To be clear, this blocks the publication of Molecules and Light, but not Greenhouse Effect, since the latter doesn't use the sounds in question.

@jbphet
Copy link
Contributor Author

jbphet commented Sep 6, 2023

There isn't much value in working on this until we are either adding the "Micro" screen to the Greenhouse Effect or we need to republish Molecules and Light from the main branch. I'm going to unassign and defer for now. This issue should be "reactivated" when work either of these two efforts begins.

@jbphet jbphet removed their assignment Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants