Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Sound) When using Self-voicing version, I hear crackling #376

Closed
terracoda opened this issue Oct 30, 2020 · 7 comments
Closed

(Sound) When using Self-voicing version, I hear crackling #376

terracoda opened this issue Oct 30, 2020 · 7 comments
Assignees

Comments

@terracoda
Copy link
Contributor

This may be related to phetsims/faradays-law#192

I am getting a noticeable crackle when I test the Self-voicing version of John Travoltage on my iPhone 7 iOS 13.7

Not sure if anything can be done, but I thought I should make an issue.

@terracoda
Copy link
Contributor Author

Assigning to both @jessegreenberg @jbphet, so both are aware of the issue. Please, re-assign or un-assign as necessary.

@jessegreenberg
Copy link
Contributor

Hmm, unfortunately I am not able to reproduce this on my Windows 10 Machine with Chrome or my iPhone 8 on 13.6.1.

@terracoda are you hearing any crackling on your phone when self-voicing is disabled? Not sure if it is related to the two playing at once or if crackling is just happening in general.

@jbphet
Copy link
Contributor

jbphet commented Apr 21, 2021

I tried to replicate this on an iPhone 8 running iOS 14.4.2, an iPad model A2270 running iOS 14.4, and in Chrome on my main development machine, which is running Windows 10. I ran the prototype self-voicing version that is currently linked on the main PhET website as a prototype, which is https://bayes.colorado.edu/dev/html/john-travoltage/1.6.0-dev.41/phet/john-travoltage_en_phet.html?supportsSelfVoicing. In none of these cases did I hear any crackling. In fact, I would say it sounded quite good in all three cases, and used different default voices, which was pretty cool.

There isn't much else I can do here, and it doesn't seem like it's worth a lot more of my time. I'm assigning back to @terracoda to make a recommendation as to whether this is a significant enough problem that we should enlist QA to try to identify devices on which the problem can be reliably repeated. If the recommendation is that the problem be investigated further, the issue should be assigned to QA.

@jbphet jbphet removed their assignment Apr 21, 2021
@emily-phet
Copy link

I heard crackling as well, when giving a demo to a teacher (using safari browser on my MacBook Pro with Big Sur).

@jessegreenberg can you send me the latest link, and I'll see if it still occurs?

@jessegreenberg
Copy link
Contributor

@emily-phet sure here is the latest link:

https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-dev.42/phet/john-travoltage_en_phet.html

Were you using Zoom to give the demo? I know in phetsims/ratio-and-proportion#229 we found that Zoom had some audio crackling, and could be related.

@emily-phet
Copy link

@jessegreenberg Thanks for the reminder re zoom and crackling. Yes, I was using Zoom. Playing with the link above for a while, I heard no crackling.

Unfortunate that this may happen quite readily with Zoom, but no need to slow publication for this. Presumably if there is a non-Zoom scenario that crackles, the QA team will find it. Otherwise, let's just chalk this up to a known Zoom issue, and hopefully whatever the root cause of it is can be addressed by Zoom in the future.

@emily-phet
Copy link

Closing this issue now. If QA finds crackling somewhere, then we can put some further time into tracking down a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants