Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic needed for Probe Key Location Map #300

Open
terracoda opened this issue Oct 23, 2024 · 1 comment
Open

Logic needed for Probe Key Location Map #300

terracoda opened this issue Oct 23, 2024 · 1 comment

Comments

@terracoda
Copy link

terracoda commented Oct 23, 2024

Currently on the descriptionProperties branch, #299

I added a location map at line 84:

const probeKeyLocationMap = {
  homePosition: 'outside beaker, near pH meter',
  atBottom: 'at bottom of beaker',
  underDropper: 'just under dropper',
  underWaterFaucet: 'under water faucet',
  halfwayOpen: 'under drain'
  otherLocationNotInSolution: 'not in solution'
}; 

And a description at line 244:

  probeLocation(( probeDescriptor: probeKeyLocationDescriptor ): string {
    return 'Probe is ${probeKeyLocationMap[ probeDescriptor ]}';
  }, 

For the dynamic description to work, the sim needs some logic that identifies the probe's location. I am not sure how involved that might be. @jessegreenberg, could you comment when you have time.

These descriptions will relevant when we add an additional keyboard shortcut to cycle the probe through these key useful locations. The other "otherLocationNotInSolution" is a catch all for all other locations and needs to be discussed.

@terracoda
Copy link
Author

Marking onhold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants