diff --git a/js/quadrilateral-main.ts b/js/quadrilateral-main.ts index 90b26d1b..447aaa7b 100644 --- a/js/quadrilateral-main.ts +++ b/js/quadrilateral-main.ts @@ -11,7 +11,6 @@ import Sim, { SimOptions } from '../../joist/js/Sim.js'; import simLauncher from '../../joist/js/simLauncher.js'; import { Node } from '../../scenery/js/imports.js'; import Tandem from '../../tandem/js/Tandem.js'; -import vibrationManager from '../../tappi/js/vibrationManager.js'; import HapticsInfoDialog from './common/HapticsInfoDialog.js'; import QuadrilateralQueryParameters from './quadrilateral/QuadrilateralQueryParameters.js'; import QuadrilateralScreen from './quadrilateral/QuadrilateralScreen.js'; @@ -97,5 +96,6 @@ simLauncher.launch( () => { // Initialize the vibration manager. This is necessary because the vibration manager needs certain things from the // sim object instance to complete its setup. If the vibration feature becomes widely used, this may be moved into // Sim.js, but as of now (May 2022) we don't want Sim.js to have a dependency on this library. - vibrationManager.initialize( sim.browserTabVisibleProperty, sim.activeProperty ); + // Removed for now until we return to this work, see https://github.com/phetsims/quadrilateral/issues/104 + // vibrationManager.initialize( sim.browserTabVisibleProperty, sim.activeProperty ); } ); \ No newline at end of file diff --git a/js/quadrilateral/QuadrilateralQueryParameters.ts b/js/quadrilateral/QuadrilateralQueryParameters.ts index 45eb7b45..3c6371cc 100644 --- a/js/quadrilateral/QuadrilateralQueryParameters.ts +++ b/js/quadrilateral/QuadrilateralQueryParameters.ts @@ -65,7 +65,7 @@ const QuadrilateralQueryParameters = QueryStringMachine.getAll( { staticAngleToleranceInterval: { type: 'number', isValidValue: ( value: number ) => value <= ( 2 * Math.PI ) && value >= 0, - defaultValue: 0.001 + defaultValue: Math.PI }, // TODO: Do we need this 'widening' of the tolerance interval when connected to a device still? diff --git a/js/quadrilateral/view/QuadrilateralScreenView.ts b/js/quadrilateral/view/QuadrilateralScreenView.ts index 13768010..5cc01605 100644 --- a/js/quadrilateral/view/QuadrilateralScreenView.ts +++ b/js/quadrilateral/view/QuadrilateralScreenView.ts @@ -29,7 +29,6 @@ import SideLengthAreaNode from './SideLengthAreaNode.js'; import QuadrilateralVisibilityControls from './QuadrilateralVisibilityControls.js'; import QuadrilateralGridNode from './QuadrilateralGridNode.js'; import QuadrilateralScreenSummaryContentNode from './QuadrilateralScreenSummaryContentNode.js'; -import vibrationManager from '../../../../tappi/js/vibrationManager.js'; import QuadrilateralAlerter from './QuadrilateralAlerter.js'; import QuadrilateralBluetoothConnectionButton from './QuadrilateralBluetoothConnectionButton.js'; import QuadrilateralPreferencesModel from '../model/QuadrilateralPreferencesModel.js'; @@ -370,7 +369,8 @@ class QuadrilateralScreenView extends ScreenView { this.quadrilateralNode && this.quadrilateralNode.step( dt ); - vibrationManager.step( dt ); + // Removed for now, see https://github.com/phetsims/quadrilateral/issues/104 + // vibrationManager.step( dt ); } } diff --git a/js/quadrilateral/view/SideNode.ts b/js/quadrilateral/view/SideNode.ts index c6d9a914..fba517fa 100644 --- a/js/quadrilateral/view/SideNode.ts +++ b/js/quadrilateral/view/SideNode.ts @@ -18,7 +18,6 @@ import QuadrilateralShapeModel from '../model/QuadrilateralShapeModel.js'; import QuadrilateralModel from '../model/QuadrilateralModel.js'; import { Line, Shape } from '../../../../kite/js/imports.js'; import QuadrilateralColors from '../../common/QuadrilateralColors.js'; -import vibrationManager from '../../../../tappi/js/vibrationManager.js'; import SideDescriber from './SideDescriber.js'; import Multilink from '../../../../axon/js/Multilink.js'; import optionize from '../../../../phet-core/js/optionize.js'; @@ -277,17 +276,17 @@ class SideNode extends Voicing( Path ) { // vibration // TODO: This code for vibration is a prototype, and only vibrates for a finite time. It will need to be improved // and finalized before publication. See https://github.com/phetsims/quake/issues/13. - side.isPressedProperty.lazyLink( isPressed => { - - if ( navigator !== undefined && navigator.vibrate !== undefined ) { - if ( isPressed ) { - vibrationManager.startVibrate( [ 200, 200 ] ); - } - else { - vibrationManager.stopVibrate(); - } - } - } ); + // side.isPressedProperty.lazyLink( isPressed => { + // + // if ( navigator !== undefined && navigator.vibrate !== undefined ) { + // if ( isPressed ) { + // vibrationManager.startVibrate( [ 200, 200 ] ); + // } + // else { + // vibrationManager.stopVibrate(); + // } + // } + // } ); } /** diff --git a/js/quadrilateral/view/VertexNode.ts b/js/quadrilateral/view/VertexNode.ts index 81f21dcc..6be3f76e 100644 --- a/js/quadrilateral/view/VertexNode.ts +++ b/js/quadrilateral/view/VertexNode.ts @@ -15,7 +15,6 @@ import Vector2 from '../../../../dot/js/Vector2.js'; import QuadrilateralModel from '../model/QuadrilateralModel.js'; import QuadrilateralColors from '../../common/QuadrilateralColors.js'; import PhetFont from '../../../../scenery-phet/js/PhetFont.js'; -import vibrationManager from '../../../../tappi/js/vibrationManager.js'; import VertexDescriber from './VertexDescriber.js'; import { Shape } from '../../../../kite/js/imports.js'; import optionize from '../../../../phet-core/js/optionize.js'; @@ -179,16 +178,16 @@ class VertexNode extends Voicing( Circle ) { this.voicingObjectResponse = vertexDescriber.getVertexObjectResponse(); // vibration - vertex.isPressedProperty.lazyLink( isPressed => { - if ( navigator !== undefined && navigator.vibrate !== undefined ) { - if ( isPressed ) { - vibrationManager.startRepeatingVibrationPattern( [ 75, 75 ] ); - } - else { - vibrationManager.stopRepeatingVibrationPattern(); - } - } - } ); + // vertex.isPressedProperty.lazyLink( isPressed => { + // if ( navigator !== undefined && navigator.vibrate !== undefined ) { + // if ( isPressed ) { + // vibrationManager.startRepeatingVibrationPattern( [ 75, 75 ] ); + // } + // else { + // vibrationManager.stopRepeatingVibrationPattern(); + // } + // } + // } ); this.mutate( options ); }