Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari issue with haptics - Mouse input no longer works #131

Closed
terracoda opened this issue Apr 20, 2022 · 5 comments
Closed

Safari issue with haptics - Mouse input no longer works #131

terracoda opened this issue Apr 20, 2022 · 5 comments
Assignees
Labels
type:bug Something isn't working

Comments

@terracoda
Copy link
Contributor

I was just using Quad in Safari and mouse input no longer works anywhere.

@jessegreenberg thought this might be related to recent haptics implementation which does work on Safari.

Alt Input with keyboard seems to work fine.

@terracoda terracoda added type:bug Something isn't working dev:a11y and removed dev:a11y labels Apr 20, 2022
@terracoda terracoda changed the title Safari Issue with Haptics - Mouse input no longer works Safari issue with haptics - Mouse input no longer works Apr 20, 2022
@jessegreenberg
Copy link
Contributor

Thanks for reporting @terracoda. We started using tappi in #104 which uses navigator.vibrate to trigger vibrations. navigator.vibrate is not available on safari so when it starts to request vibrations the sim will crash on that platform. We need to do something like prevent its usage on safari or conditionally use tappi in quad or improve tappi to no-op on Safari.

@jbphet do you have a preference for how we continue with tappi work with this issue?

@jbphet
Copy link
Contributor

jbphet commented Apr 20, 2022

Interesting. I think we should implement some sort of guard to prevent problems on platforms that don't support vibration. In the short term, we could just remove the code if it's causing significant problems for people, and add it back with the guards when we work on this next week.

@jbphet
Copy link
Contributor

jbphet commented Apr 20, 2022

@terracoda - I've pushed some changes that should prevent this issue on Safari. However, I don't have a good way to test it. Please try it out and let us know if the problem with mouse input is resolved.

@terracoda
Copy link
Contributor Author

I can use mouse input. Seems fixed :-)

@terracoda
Copy link
Contributor Author

Thanks @jbphet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants