-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename sides to use corner labels instead of positional names #79
Comments
@jessegreenberg, the corners have been renamed, but the sides still need to be re-named. For description orientation accuracy, the model will need a way of determining what corner and side to start with the state descriptions. I will open a separate issue for that. |
This is done in the strings but I haven't updated the model yet. One interesting thing to consider is the pronunciation of the side letters with screen readers and SpeechSynthesis. For me Chrome reads out "Side DA" as "Side Dah". @terracoda do we need to do anything about this? Once we confirm this is OK I will update the model to match these names. |
I thought that DA would be a problem. Can you put a space in between D and A, and see if it solves the issue? It would be nice just to compare. |
Actually, I'll test with VO, first. |
I have changed my mind. Do not add a space. The pronunciation will vary between Voices and platforms. I hear Side DA as separate letters D A in Safari with WebSpeech and with VoiceOver. Let's leave it with no space, unless of course, you already added a space and I am hearing D A because you added a space. |
@jessegreenberg please update the names in the model and close this issue. |
Sounds good. No, I had not made any changes here yet. |
The sides have been renamed. Thanks @jessegreenberg. Closing. |
Rename sides
The same side names are noted in the Interactive Description design doc.
Names across Voicing and Interactive Description ideally will remain in synch.
The text was updated successfully, but these errors were encountered: