Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sides to use corner labels instead of positional names #79

Closed
terracoda opened this issue Feb 24, 2022 · 9 comments
Closed

Rename sides to use corner labels instead of positional names #79

terracoda opened this issue Feb 24, 2022 · 9 comments

Comments

@terracoda
Copy link
Contributor

Rename sides

  • Top Side - > Side AB
  • Right Side - > Side BC
  • Bottom Side - > Side CD
  • Left Side - > Side DA

The same side names are noted in the Interactive Description design doc.
Names across Voicing and Interactive Description ideally will remain in synch.

@terracoda
Copy link
Contributor Author

@jessegreenberg, the corners have been renamed, but the sides still need to be re-named.

For description orientation accuracy, the model will need a way of determining what corner and side to start with the state descriptions. I will open a separate issue for that.

@terracoda
Copy link
Contributor Author

The names of the objects will be the same in Interactive description, see issue #76 and checklist issue #74.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Mar 14, 2022

This is done in the strings but I haven't updated the model yet. One interesting thing to consider is the pronunciation of the side letters with screen readers and SpeechSynthesis.

For me Chrome reads out "Side DA" as "Side Dah". @terracoda do we need to do anything about this? Once we confirm this is OK I will update the model to match these names.

@terracoda
Copy link
Contributor Author

I thought that DA would be a problem. Can you put a space in between D and A, and see if it solves the issue? It would be nice just to compare.

@terracoda
Copy link
Contributor Author

Actually, I'll test with VO, first.

@terracoda
Copy link
Contributor Author

terracoda commented Mar 15, 2022

I have changed my mind. Do not add a space.

The pronunciation will vary between Voices and platforms. I hear Side DA as separate letters D A in Safari with WebSpeech and with VoiceOver.

Let's leave it with no space, unless of course, you already added a space and I am hearing D A because you added a space.

@terracoda
Copy link
Contributor Author

terracoda commented Mar 15, 2022

@jessegreenberg please update the names in the model and close this issue.

@jessegreenberg
Copy link
Contributor

Sounds good. No, I had not made any changes here yet.

@terracoda
Copy link
Contributor Author

The sides have been renamed. Thanks @jessegreenberg. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants